Bump react-native-live-markdown - #99324
Conversation
|
|
|
@abzokhattab @situchan One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 83443fe089
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - React-Core-prebuilt (0.86.0): | ||
| - ReactNativeDependencies |
There was a problem hiding this comment.
Keep the pod lockfile source-built
The supported standalone pod-install command explicitly sets both RCT_USE_RN_DEP=0 and RCT_USE_PREBUILT_RNCORE=0, but this lockfile now resolves React-Core-prebuilt (and ReactNativeDependencies). Consequently, running npm run pod-install or npm run pod-install-standalone after this dependency update resolves a different source-built pod graph and regenerates the lockfile/Xcode project again. Preserve the previous source-built resolution unless the installation script is intentionally changed to enable prebuilt RN Core.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Should be fine now
|
This was already tested in upstream PR |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppios1.movios2.moviOS: mWeb SafariMacOS: Chrome / Safari |
| React: 2574546f2d017abd14d0c9b48cf2b6a0547c2591 | ||
| React-callinvoker: b997d4d109c92cae4bc7f1edb08dc6a7c11a1ca2 | ||
| React-Core: 5c7a37fd611353c8bf1c12ef24cfdec81ff46549 | ||
| React-Core: ee317fb557001c3972bcf4fe15996197e65ae54d |
There was a problem hiding this comment.
Please undo unrelated changes in this file
Explanation of Change
The app froze and got killed on iOS while typing in the composer (Sentry APP-EF1).
This PR bumps
react-native-live-markdownto the version that includes the $ Expensify/react-native-live-markdown#772Fixed Issues
$ #93831
PROPOSAL:
Tests
strike,code, > quote, # heading, a link and an @mention.Offline tests
QA Steps
strike,code, > quote, # heading, a link and an @mention.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-08-17.at.15.07.40.mov
iOS: mWeb Safari
MacOS: Chrome / Safari