fix: take Windows resources from the kernal-api-build companion package - #253
Merged
Merged
Conversation
The macOS ARM Live Test has failed on main since 80b7799: its Linux cross-build could not compile glib-sys. `viewer = ["kernal-api/tauri-webview"]` applies to every dependency named kernal-api, including the build dependency added for Windows resources, so the host build script pulled in Tauri, GTK and glib. Renaming that dependency is rejected by Cargo, which refuses one package under two names. kernal-api v0.1.7 ships the capability as the separate kernal-api-build package instead, so no application feature can reach it. build.rs now depends on that package alone, and the boundary test requires exactly that shape. Verified on Linux against v0.1.7: `cargo tree` shows the build dependency is only kernal-api-build with no glib-sys for the macOS target; Rust workspace tests (303/3/1/1), Python tests (45 passed, 1 skipped) and `bash lint` pass; and a fastled.exe cross-built for x86_64-pc-windows-msvc still embeds RT_ICON, RT_GROUP_ICON (32512), RT_VERSION ("FastLED Viewer", "fastled", 2.0.20) and the Common-Controls v6 RT_MANIFEST. Refs #242 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VfXV1EpgAvMZzXJfbGZPRG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main's macOS ARM Live Test has failed since 80b7799: the Linux cross-build could not compile
glib-sys.viewer = ["'kernal-api/tauri-webview'"]applies to every dependency namedkernal-api, including the build-dependency that #242 added for Windows executable resources. The host build script therefore compiled Tauri, GTK and glib, which the macOS cross runner does not install. Renaming the build-dependency is rejected: Cargo refuses one package under two names.kernal-api v0.1.7 ships the capability as the separate
kernal-api-buildpackage (zackees/kernal-api#278), which no application feature can reach.crates/fastled-cli/build.rsnow uses that package alone, and the boundary test requires exactly that shape.Validation on Linux
cargo tree --target aarch64-apple-darwin -e build: the build-dependency is onlykernal-api-build;glib-sysis unreachable for that target.bash lint: clean.fastled.execross-built forx86_64-pc-windows-msvcembedsRT_ICON,RT_GROUP_ICON(32512),RT_VERSION("'FastLED Viewer"' / "'fastled"' / 2.0.20) and the Common-Controls v6RT_MANIFEST.🤖 Generated with Claude Code
https://claude.ai/code/session_01VfXV1EpgAvMZzXJfbGZPRG