ci: install GTK/WebKit dev packages before setup-soldr - #263
Merged
Merged
Conversation
soldr-cook builds glib-sys/gobject-sys, which resolve GTK/WebKit through pkg-config. With the apt install after setup-soldr, cooking failed with exit 101 and every run recompiled those deps cold. Move the "Install system dependencies" step ahead of zackees/setup-soldr@v0.9.62 in all six Linux-cooking workflows (_unit-test, _integration-test, _lint, _terminal-test, _build, linux-x86-dwarf-smoke). In _build.yml the step stays after "Configure Rust target" so rust-toolchain.ci.toml still exists when setup-soldr reads it. Refs #262 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
zackees
added a commit
that referenced
this pull request
Sep 18, 2026
CLI: - `fastled <sketch>` no longer crashes with "Cannot drop a runtime" after starting the server (#269). - `--terminal-cmd` / FASTLED_TERMINAL_CMD runs an agent in the browser terminal, and a configured session survives a page reload through a single-use reattach token (#254, #267). Terminal: - The shell starts in the named directory and emits valid exit frames (#257). - A client that disconnects mid-write releases its session slot (#256, #258). Viewer: - Screen maps registered after setup() now reach the renderer, so sketches like Blink no longer show an empty canvas (#250, #264). - The page no longer overflows the window by 40 px, and the title scales with the window (#268, #270). CI: - Browser terminal suite on Linux, Windows and real Safari (#259, #260). - Linux render smoke that fails on a blank canvas (#247, #266). - Linux dependencies install before setup-soldr, so the dependency cook succeeds (#263); lint covers ci/ (#265); an Intel macOS guest WebKit probe (#251, #261). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #262
soldr-cook(theprebuild-depsstep ofcache-preset: foundation) buildsglib-sys/gobject-sys, whose build scripts resolve GTK/WebKit throughpkg-config. The apt install step was running after
zackees/setup-soldr@v0.9.62, so cooking failed with exit 101 and every runthen compiled those deps cold.
Move the
Install system dependenciesstep ahead ofsetup-soldrin all sixLinux-cooking workflows:
_unit-test.yml,_integration-test.yml,_lint.yml,_terminal-test.yml,_build.yml,linux-x86-dwarf-smoke.yml.The step body and its
if: runner.os == 'Linux'guard are unchanged — this isa pure move plus a 3-line comment explaining the ordering constraint.
In
_build.ymlthe step is placed afterConfigure Rust targetsorust-toolchain.ci.tomlstill exists whensetup-soldrreads it.The remaining Linux-hosted
setup-soldrjobs (macos-arm-live-test.ymlcross-build,
macos-x64-guest-webkit-probe.yml) cross-compile to Apple targetswith a different pinned action and no foundation preset, so they never build
Linux
glib-sys/gobject-sysand are left alone.act evidence
act workflow_dispatch -W .github/workflows/linux-x86-unit-test.yml --pull=false -P ubuntu-24.04=catthehacker/ubuntu:act-24.04, run twice against the same act cache.Run 1 (cold cache) —
Job succeeded, exit 0:Run 2 (warm cache) —
Job succeeded, exit 0:setup-soldr drops from 2m32s to 21.6s and
soldr cookfrom 102.6s to 0.4s, i.e.the cook now succeeds and its cache is actually reused instead of being rebuilt
cold every run.
Also verified: exactly one
libwebkit2gtk-4.1-devoccurrence per file with theapt line before the
setup-soldrline in all six workflows, and every.github/workflows/*.ymlstill parses as YAML.🤖 Generated with Claude Code