Translate XMLStreamReader creation errors to StreamReadException - #883
Merged
cowtowncoder merged 5 commits intoJul 24, 2026
Merged
Conversation
XMLStreamReader creation errors to StreamReadException
Member
|
TBH, this sounds like SJSXP bug we should not pave over -- it really should not leak AAOOBEs. I'll need to think about this a bit... |
Contributor
Author
|
Agreed, the root cause is SJSXP and ideally it gets fixed there. The reason I went this route is that the next() path already translates the exact same AIOOBE from the SJSXP decoder (Stax2JacksonReaderAdapter, from #618), so createXMLStreamReader() looked like the one remaining boundary where it still escapes as a raw runtime exception. No urgency on my end, happy to adjust if you'd rather handle it differently. |
cowtowncoder
approved these changes
Jul 24, 2026
Member
|
@Sahana2524 actually I agree with your assessment after thinking it through: this is one-off on construction and there's earlier precedents. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XmlFactory._createParser catches only XMLStreamException around createXMLStreamReader:
ArrayIndexOutOfBoundsExceptionthrown for invalid ending XML string when using JDK default Stax XML parser #618) parse the XML declaration during reader creation and can throw ArrayIndexOutOfBoundsException on malformed inputArrayIndexOutOfBoundsExceptionthrown for invalid ending XML string when using JDK default Stax XML parser #618); the create boundary was the gapWrapped it in all four _createParser overloads; the test uses a stand-in factory that throws at reader creation.