Repository navigation
Conversation
…ithout extra filing An owner could invite a colleague directly to an item the colleague already saw through a shared folder, because the share dialog and the copy-link popover counted direct invitations only. Accepting that invitation required filing it into one of the receiver's own folders, so the item showed up twice in the receiver's tree. Owner side: - GET /api/items/[id]/shares also returns the folder audience: the folder owner and pending or accepted folder receivers, labelled with the item owner's own folder or attachment name. - The share dialog groups people by folder, labels them in search, offers no direct invite for them and links to the folder's sharing (folder owner only). inviteToItem skips them. - Copy link is never blocked. The popover and the header count distinct people across direct and folder access. Receiver side: - Invitations list the receiver's own accepted folder paths to the item. - Accept without a folder is allowed only when such a path exists, rechecked inside the share transaction. The same rule lets the receiver remove an extra filing again. - Ordinary invitations still require filing, and the dialog says why. - One ReceivedItemDialog body serves acceptance and later filing for recordings and mail. Folders created in it reach the dashboard state. - Removing a direct share says where the item stays visible and keeps the row. No schema change. Decision record: 2026-10-31-share-acceptance-with-existing-folder-access.
fix(sharing): show folder access when sharing an item and accept it without extra filing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.