Repository navigation
web(deps): resolve SvelteKit cookie audit advisory #54
Copy link
Copy link
Closed
Description
Evidence
npm ci on main at a85b909 reports three low-severity audit entries which are one dependency chain:
- direct
@sveltejs/kit2.70.3; - direct
@sveltejs/adapter-static3.0.10, affected through Kit; - transitive
cookie0.6.0, affected by GHSA-pxg6-pf52-xh8x (cookieaccepts out-of-bounds characters in cookie name, path, and domain).
npm audit --json reports no moderate, high, or critical findings. The suggested automated fix incorrectly proposes old semver-major package versions (@sveltejs/kit 0.0.30 or adapter-static 0.0.17), so npm audit fix --force is not an acceptable remedy. Consolebook uses SvelteKit only to build a static SPA; Rust/Axum owns runtime cookies.
Outcome
Evaluate the first compatible Kit release or a safe lockfile/override update that carries cookie >=0.7.0, confirm the static-build threat boundary, and run npm ci, npm audit, npm run check, npm run build, the Rust gates, and browser tests before merging. Do not suppress the advisory without a documented reason.
Execution record (2026-10-15)
- Authority: the maintainer, 2026-10-15, local session: "yes please do so. i'd like to use latest versions of packages here where it makes sense in general". This came in reply to taking web(deps): resolve SvelteKit cookie audit advisory #54 after Dependabot's chore(deps): bump cookie, @sveltejs/adapter-static and @sveltejs/kit in /web #134 failed to install, plus the standing permission to manage PRs end to end, including merging.
- Scope (widened by that instruction): move the web stack to its latest stable releases wherever that makes sense. That covers SvelteKit 3, adapter-static 4, vite-plugin-svelte 7, and their Vite, Svelte, and TypeScript peers, plus the other direct dev dependencies (svelte-check, Playwright, …). The
cookieadvisory (GHSA-pxg6-pf52-xh8x, Dependabot alert Implement Milestone 1 operable-shell foundation #1) closes as a result. Rust crates, the toolchain, and Actions pins are separate PRs, one per ecosystem. Keeping versions current from now on is mechanical: Dependabot version updates, in their own change. - Plan:
- A scout inventories the outdated packages, their breaking changes, the compatible version set, and the Node minimum.
- The implementer migrates from a fixed brief.
- An independent reviewer reviews.
- A verifier runs the full proof, and the browser suite must pass unchanged unless a breaking change requires otherwise.
- The PR merges under the standing permission.
- Next action: take the scout's inventory, then brief the migration.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Activity
TusanHomichi commentedon Oct 15, 2026
Update (2026-10-15): with the dependency graph now enabled (#131), Dependabot opened #134 for this chain:
cookie0.6.0 → 2.0.1,@sveltejs/kit^2 → ^3.1.0,@sveltejs/adapter-static^3 → ^4. It fails at install. Kit 3.1.0 peers@sveltejs/vite-plugin-svelte@^7.0.0against our^6(ERESOLVE, run 38787555488). So resolving this advisory means migrating to SvelteKit 3 as a whole: vite-plugin-svelte 7, its Vite and Svelte peer ranges, adapter-static 4, and whatever breaking changes Kit 3 brings to a static SPA. That needs to be proven with the full gate and the browser suite. I closed #134 with that explanation. Dependabot alert #1 (GHSA-pxg6-pf52-xh8x, low) remains open against this issue. The other five open alerts, all for devalue and source-map-js, are fixed in #135.fix(web): update devalue and source-map-js past their high advisories (…
deps(web): move to SvelteKit 3, Vite 8, and current web tooling
fix(web): remove the unreachable resume control and document the brow…
deps(web): SvelteKit 3, Vite 8, and current web tooling (#140)
TusanHomichi commentedon Oct 15, 2026
Merged in #140 as
21fe68d725a21680ff16755b461253e95014261a(squash, single parent909bf92). The merged treebc172ff6is identical to the combined head32b5942, which was proven locally with Rust 1.99.1 after the rebase onto #139: 7/7 gates, 292 Rust tests, 62/62 browser tests,npm audit0, receipt sha256c422ec60…. Hostedfmt-clippy-test,build-x86_64,build-aarch64, and CodeQL passed on that head. Codex reviewed both heads and found nothing. Thecookieadvisory (GHSA-pxg6-pf52-xh8x) is gone from the lockfile (cookie2.0.1); Dependabot alert #1 should mark itself fixed on its next scan. Authority: the maintainer's dependency policy and standing PR permission.