Skip to content

fix: retry rejected lifecycle termination requests - #713

Merged
silent-cipher merged 2 commits into
mainfrom
fix/retry-termination
Sep 24, 2026
Merged

silent-cipher merged 2 commits into
mainfrom
fix/retry-termination

Conversation

@silent-cipher

Copy link
Copy Markdown
Collaborator

Summary

  • Retry lifecycle-check termination requests up to three times when the SP returns TerminateServiceError.
  • Wait 10 seconds between attempts and stop promptly if the job if aborted.
  • Keep retries opt-in so existing terminateServiceSync callers retain single-attempt behavior.

Why

Transient SP chain-node failures can reject termination before anything is submitted on-chain, leaving lifecycle-check data sets active. Retrying these specific failures reduces leaked throwaway data sets.

Copilot AI lite review requested due to automatic review settings September 24, 2026 05:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@FilOzzy FilOzzy added this to FOC Sep 24, 2026
@github-project-automation github-project-automation Bot moved this to 📌 Triage in FOC Sep 24, 2026

@beck-8 beck-8 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking suggestion:

  • Comment and documentation (apps/backend/src/data-set-lifecycle/data-set-lifecycle.service.ts:58) are too absolute: SDK's TerminateServiceError also covers other HTTP errors, and it cannot be claimed that "it is definitely not submitted to the chain" solely based on this type.

@github-project-automation github-project-automation Bot moved this from 🔎 Awaiting review to ✔️ Approved by reviewer in FOC Sep 24, 2026
@silent-cipher
silent-cipher merged commit 92b8dba into main Sep 24, 2026
9 checks passed
@silent-cipher
silent-cipher deleted the fix/retry-termination branch September 24, 2026 17:24
@github-project-automation github-project-automation Bot moved this from ✔️ Approved by reviewer to 🎉 Done in FOC Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

4 participants