fix: retry rejected lifecycle termination requests - #713
Merged
Merged
Conversation
beck-8
approved these changes
Sep 24, 2026
beck-8
left a comment
Member
There was a problem hiding this comment.
Non-blocking suggestion:
- Comment and documentation (apps/backend/src/data-set-lifecycle/data-set-lifecycle.service.ts:58) are too absolute: SDK's TerminateServiceError also covers other HTTP errors, and it cannot be claimed that "it is definitely not submitted to the chain" solely based on this type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Transient SP chain-node failures can reject termination before anything is submitted on-chain, leaving lifecycle-check data sets active. Retrying these specific failures reduces leaked throwaway data sets.