Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #492
Summary
Teach the Gemma 4 checkpoint reader to load the mixed compressed-tensors layout used by
unsloth/gemma-4-26B-A4B-it-NVFP4:weight_scaleroles alongside their weights and normalize[out_features, 1]bf16 scales to FreeToken's flat fp32 buffers;nvfp4_parts_ct/ct_nvfp4_fusehelpers;The existing ModelOpt Gemma 4 path is retained unchanged.
Tests
Weight-free regression coverage:
Real-hardware validation:
cac247a(0.1.3)unsloth/gemma-4-26B-A4B-it-NVFP4/v1/models, and/v1/chat/completionsall completedExact serve command is included in the linked issue.
AI assistance was used to prepare the patch and tests. The contributor reviewed the behavior and ran the real-checkpoint validation described above.