Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ def multiply(self, other):
new_mu = linalg.solve(new_precision, information_vector)
new_C = linalg.solve(new_precision, identity)
new_C = 0.5 * (new_C + transpose(new_C))
return GaussianDistribution(new_mu, new_C, check_validity=False)
return type(self)(new_mu, new_C, check_validity=False)

def convolve(self, other):
"""Convolve two independent Gaussian distributions.
Expand All @@ -343,7 +343,7 @@ def convolve(self, other):
_validate_same_dimension(self, other, "convolve")
new_mu = self.mu + other.mu
new_C = self.C + other.C
return GaussianDistribution(new_mu, new_C, check_validity=False)
return type(self)(new_mu, new_C, check_validity=False)

def marginalize_out(self, dimensions):
"""Return the marginal distribution after dropping dimensions.
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
"""Regression tests for Gaussian subclass preservation."""

import unittest

from pyrecest.backend import array
from pyrecest.distributions import GaussianDistribution


class _DerivedGaussian(GaussianDistribution):
"""Minimal derived Gaussian used to verify operation return types."""


class TestGaussianDistributionSubclassOperations(unittest.TestCase):
def setUp(self):
self.derived = _DerivedGaussian(array([0.0]), array([[2.0]]))
self.other = GaussianDistribution(array([1.0]), array([[3.0]]))

def test_multiply_preserves_left_hand_subclass(self):
result = self.derived.multiply(self.other)

self.assertIsInstance(result, _DerivedGaussian)

def test_convolve_preserves_left_hand_subclass(self):
result = self.derived.convolve(self.other)

self.assertIsInstance(result, _DerivedGaussian)


if __name__ == "__main__":
unittest.main()
Loading