docs(con): reconcile current-main lifecycle plan - #261
Conversation
|
Warning Review limit reached
Next review available in: 53 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughWS-CON-001 is reconciled with the current repository state. The planning documents now define subsystem ownership, partial-order dependencies, authorization boundaries, receipt restrictions, verification requirements, and a planning-only stop before runtime implementation. ChangesContribution-compensation planning
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
@.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/chunks/WS-CON-001-03D-delivery-receipt-status-persistence.md:
- Around line 50-55: Clarify the receipt-storage allowlist in the relevant
persistence criteria to restrict exact quantities to the canonical award
quantity and binding unit, and canonical digests to platform-generated digests
derived exclusively from approved receipt fields. Explicitly reject digests
computed from provider bodies, tokens, signatures, URLs, PII, balances, ledgers,
settlement data, or other forbidden inputs, and add rejection tests covering
those digest inputs.
In
@.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/CONFORMANCE_MATRIX.md:
- Line 8: Update the Authorization row in CONFORMANCE_MATRIX.md to state that
CON mappings, identities, and static rows are currently absent on main, and
require exact AUTH-owned registration and activation evidence for every future
artifact. Remove the runtime-inspection exception so inspection alone cannot
satisfy or waive the AUTH gate, while preserving the existing AUTH activation
and CON-11 references.
In
@.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/RISKS.md:
- Line 15: Update the provider receipt mitigation to explicitly deny sensitive
provider, secret, token, signature, URL, PII, balance, ledger, and settlement
data instead of referring only to bounded non-secret facts. Repeat the same
complete exclusion list in the future receipt contract, keeping receipt
persistence limited to bounded non-sensitive facts.
In `@docs/spec_contribution_compensation.md`:
- Around line 894-895: Synchronize the dependency graphs with the child chunk
contracts: in docs/spec_contribution_compensation.md lines 894-895, add CON-04A
as a predecessor of CON-04B; in lines 918-920, add CON-03B as a predecessor of
CON-03C; in
.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/CHUNK_MAP.md
lines 36-39 and 64-65, add CON-04A and CON-04B to the CON-08A entry gate and
dependency view.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 82523071-8712-467f-bf91-683752794ef0
📒 Files selected for processing (22)
.agent-loop/REVIEW_LOG.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/ACTIVE_DOC_INVENTORY.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/AUTHORIZATION_HANDOFF.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/CHUNK_MAP.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/CONFORMANCE_MATRIX.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/DECISIONS.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/DISCOVERY.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/INTENT.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/JOINT_RELEASE_HANDOFF.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/PLAN.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/RISKS.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/SOURCE_MANIFEST.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/STATUS.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/chunks/WS-CON-001-02B-shared-outbox-dispatcher.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/chunks/WS-CON-001-02C-shared-lifecycle-audit-participant.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/chunks/WS-CON-001-03A-adapter-binding-persistence.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/chunks/WS-CON-001-03B-contribution-policy-persistence.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/chunks/WS-CON-001-03D-delivery-receipt-status-persistence.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/chunks/WS-CON-001-PLAN4-current-main-reconciliation.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/reviews/WS-CON-001-PLAN4-pr-trust-bundle.md.agent-loop/merge-intents/WS-CON-001-PLAN4.jsondocs/spec_contribution_compensation.md
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/chunks/WS-CON-001-08A-outbound-compensation-delivery.md (1)
9-19: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winAdd
CON-03Dto the explicit CON-08A prerequisite gate.Line 11 lists CON-04A, CON-04B, CON-07, and the shared dispatcher.
docs/spec_contribution_compensation.mdLine 903 also requires CON-03D before CON-08A. The CON-03D chunk owns delivery-receipt status persistence. Without this child-contract gate, CON-08A can start against an incomplete receipt contract.Add CON-03D to the prerequisite list, or state that CON-08A intentionally implements and supersedes the CON-03D contract.
Proposed prerequisite update
- - CON-04A binding behavior, CON-04B policy behavior, CON-07, and shared outbox - dispatcher are merged; + - CON-03D delivery-receipt status persistence, CON-04A binding behavior, + CON-04B policy behavior, CON-07, and shared outbox dispatcher are merged;🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/chunks/WS-CON-001-08A-outbound-compensation-delivery.md around lines 9 - 19, Update the CON-08A “Prerequisites” section to explicitly include CON-03D alongside CON-04A, CON-04B, CON-07, and the shared outbox dispatcher. Preserve the existing prerequisite wording, unless the implementation intentionally owns and supersedes the CON-03D delivery-receipt status persistence contract; in that case, state that explicitly.docs/spec_contribution_compensation.md (1)
891-913: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winUse the exact REV-04B runtime gate in the canonical dependency views.
Line 898 uses
REV FinalAcceptance foundation. Lines 923-926 useREV-04 Review/FinalAcceptance persistence. The CON-03C contract requires merged runtimeFinalAcceptance,Review, andReviewLeasetargets and rejects planning records as gate evidence. Replace the broad labels withREV-04B runtime Review/ReviewLease/FinalAcceptancein both locations.This keeps the canonical order identical to the child contract and prevents partial or planning-only REV persistence from satisfying the predecessor.
Proposed dependency wording
- REV FinalAcceptance foundation -> CON-03C -> CON-03D + REV-04B runtime Review/ReviewLease/FinalAcceptance + -> CON-03C -> CON-03D ... - REV-04 Review/FinalAcceptance persistence + CON-03B + REV-04B runtime Review/ReviewLease/FinalAcceptance + CON-03B -> CON-03C exact contribution source schemaAlso applies to: 923-926
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/spec_contribution_compensation.md` around lines 891 - 913, Replace the broad REV predecessor labels in both canonical dependency views—including the dependency entry currently using “REV FinalAcceptance foundation” and the later REV-04 persistence references—with the exact gate label “REV-04B runtime Review/ReviewLease/FinalAcceptance.” Ensure both views require merged runtime Review, ReviewLease, and FinalAcceptance targets, not planning records or partial persistence, matching the CON-03C contract.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In
@.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/chunks/WS-CON-001-08A-outbound-compensation-delivery.md:
- Around line 9-19: Update the CON-08A “Prerequisites” section to explicitly
include CON-03D alongside CON-04A, CON-04B, CON-07, and the shared outbox
dispatcher. Preserve the existing prerequisite wording, unless the
implementation intentionally owns and supersedes the CON-03D delivery-receipt
status persistence contract; in that case, state that explicitly.
In `@docs/spec_contribution_compensation.md`:
- Around line 891-913: Replace the broad REV predecessor labels in both
canonical dependency views—including the dependency entry currently using “REV
FinalAcceptance foundation” and the later REV-04 persistence references—with the
exact gate label “REV-04B runtime Review/ReviewLease/FinalAcceptance.” Ensure
both views require merged runtime Review, ReviewLease, and FinalAcceptance
targets, not planning records or partial persistence, matching the CON-03C
contract.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 4c2f80f0-1098-44b3-a13e-6707b7523df3
📒 Files selected for processing (20)
.agent-loop/REVIEW_LOG.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/ACTIVE_DOC_INVENTORY.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/AUTHORIZATION_HANDOFF.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/CHUNK_MAP.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/CONFORMANCE_MATRIX.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/DISCOVERY.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/INTENT.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/JOINT_RELEASE_HANDOFF.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/PLAN.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/RISKS.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/SOURCE_MANIFEST.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/STATUS.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/chunks/WS-CON-001-03A-adapter-binding-persistence.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/chunks/WS-CON-001-03C-contribution-award-persistence.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/chunks/WS-CON-001-03D-delivery-receipt-status-persistence.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/chunks/WS-CON-001-04B-hidden-contribution-policy-service.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/chunks/WS-CON-001-08A-outbound-compensation-delivery.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/reviews/WS-CON-001-PLAN4-external-review-response.md.agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/reviews/WS-CON-001-PLAN4-pr-trust-bundle.mddocs/spec_contribution_compensation.md
🚧 Files skipped from review as they are similar to previous changes (12)
- .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/RISKS.md
- .agent-loop/REVIEW_LOG.md
- .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/chunks/WS-CON-001-03A-adapter-binding-persistence.md
- .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/ACTIVE_DOC_INVENTORY.md
- .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/reviews/WS-CON-001-PLAN4-pr-trust-bundle.md
- .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/SOURCE_MANIFEST.md
- .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/chunks/WS-CON-001-03D-delivery-receipt-status-persistence.md
- .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/AUTHORIZATION_HANDOFF.md
- .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/CONFORMANCE_MATRIX.md
- .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/CHUNK_MAP.md
- .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/JOINT_RELEASE_HANDOFF.md
- .agent-loop/initiatives/WS-CON-001-contribution-compensation-boundary/PLAN.md
…ain-reconciliation' into codex/ws-con-001-plan4-current-main-reconciliation
Chunk
WS-CON-001-PLAN4 — Current-Main Reconciliation.
Goal
Reconcile the complete contribution/compensation plan with current main without starting runtime implementation.
Human-approved intent
Pull latest main, repair every stale/conflicting plan and document, review ART/AUTH/REV alignment end to end, fix review findings, and publish a PR if needed.
What changed
Why it changed
Merged AUTH/ART/REV work made the old linear plan stale. It blocked independent persistence on dispatcher authority and omitted cross-chunk gates.
Design chosen
Use a capability-based partial order while preserving custody: AUTH owns authority; ART owns bytes/provider access; REV owns review lifecycle and the decision commit; CON owns policy, contribution, award, and fulfillment facts.
Alternatives rejected
Scope control / allowed files
Only WS-CON planning/review artifacts, the PLAN4 merge intent, the PLAN4 review-log entry, and the bounded canonical contribution specification sections. Exact paths are in the PLAN4 contract.
Not allowed: runtime, migrations, routes, activation, workflows, dependencies, CI changes, tests, other initiative edits, roadmaps, exports, or archival reference inputs.
Product behavior
No product behavior changes. Planning/specification only.
Acceptance criteria proof
Tests/checks run
All local checks pass. Hosted Backend and Agent Gates passed on the first PR head; refreshed checks are running for the repair head.
Test delta
No test files changed. No assertions, coverage floors, workflows, or CI controls were weakened.
CI integrity
No workflow, dependency, test-runner, package, or coverage configuration changed. The first hosted Backend run passed every lane and aggregate test.
Reviewer results
External review
CodeRabbit raised four valid findings. All were repaired in commit 94bfb3b and recorded in WS-CON-001-PLAN4-external-review-response.md. Refreshed CodeRabbit review is pending.
Remaining risks
ART #249 remains open, so migration allocation must be refreshed. AUTH registrations, legacy-row classification, REV runtime targets, and callback/provider contracts remain future gates.
Follow-up work
After PLAN4 merges and human approval, refresh main and implement only CON-03A. Do not start later chunks automatically.
Human review focus
Review the partial order, dispatcher deferral, REV lease/FinalAcceptance dependencies, receipt minimization/digest provenance, and excluded PDF.
Human merge ownership
Only the human may approve and merge this PR.
Summary by CodeRabbit