feat(DataRetentionSettingsForm): per-store data retention settings element - #244
Open
brettflorio wants to merge 6 commits into
Open
brettflorio wants to merge 6 commits into
brettflorio wants to merge 6 commits into
Conversation
…ement foxy-data-retention-settings-form edits fx:data_retention_settings: a toggle (auto_anonymize) and a conditional days-of-inactivity field with a 90-day minimum (v8n + min). Mirrors CustomerPortalSettingsForm (PATCH-only settings singleton: delete/timestamps hidden). Includes i18n, tests, and a story. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…dataset Populated fixture + store link so the storybook Playground loads an editable data_retention_settings resource. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Brett Florio seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Brett Florio seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
…field data_retention now lives on the Store resource (not a sub-resource), so the form binds to a store and edits the nested data_retention object via custom get/set + this.edit() (the StoreForm pattern). Update v8n/hiddenSelector to read data_retention.*, stories to a store href, and tests. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UGvyb3Yx7kGiTWfaVnBa4u
…e field The form edits the store's `data_retention` field, but the demo server still carried a `data_retention_settings` collection from the earlier sub-resource design. Nothing referenced it. - drop the orphan collection and its links entry - add `data_retention` to the demo store so it carries the field - regenerate the test groups so the new element's tests get a group Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Data retention lives in the store's `data_retention` field, so it belongs in the store form rather than in an element of its own. Adds a "Data retention" summary section with the auto-anonymize switch and the days-of-inactivity number control, and drops the standalone DataRetentionSettingsForm. - v8n: 90-day minimum, days required while auto-anonymize is on - days control only renders while auto-anonymize is on - tests moved into the StoreForm suite Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
pheekus
previously approved these changes
Sep 17, 2026
Contributor
|
@brettflorio I've moved data retention settings into |
Contributor
|
Let me fix that Netlify build first though. |
The lockfile pinned 1.16.2, whose Store graph has no `data_retention`, so
`edit({ data_retention })` failed the build with TS2345.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
Ah it was an old SDK version. @brettflorio ready to merge now. |
pheekus
self-requested a review
September 17, 2026 22:43
pheekus
approved these changes
Sep 17, 2026
Contributor
Author
|
@filipcujanovic This one's done now, if you needed it for the other related PRs. cc @adamjudd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataRetentionSettingsForm — edits the store's
data_retentionfielddata_retentionnow lives on the Store resource (not adata_retention_settingssub-resource), so the form is Store-typed and edits the nesteddata_retentionobject via customgetValue/setValue+this.edit()(theStoreFormnested-JSON-field pattern).auto_anonymize(switch) +auto_anonymize_days(number, min 90); v8n andhiddenSelectorreaddata_retention.*; days control hidden unless auto-anonymize is on.data_retentioncase). Suite green.Requires the foxy-sdk change adding
data_retentionto the Store graph.