Skip to content

deps: introduce cppgsl dependency for C++ core guidelines support - #17

Merged
knoepfel merged 2 commits into
mainfrom
cppgsl-dep
Aug 21, 2026
Merged

deps: introduce cppgsl dependency for C++ core guidelines support#17
knoepfel merged 2 commits into
mainfrom
cppgsl-dep

Conversation

@knoepfel

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6dee2203-a013-4ba5-954f-3dfc32804964


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greenc-FNAL greenc-FNAL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular minimum version of cppgsl required for the features you're currently using?

@knoepfel

Copy link
Copy Markdown
Member Author

Is there a particular minimum version of cppgsl required for the features you're currently using?

@greenc-FNAL, I just pushed a change that requires version 4 of cppgsl or greater. PR Framework-R-D/phlex#839 assumes that the installed headers accord with a pattern that was introduced in version 4 (e.g.):

- #include <gsl/gsl_pointers>  // Before v4
+ #include <gsl/pointers>      // v4 and later

@knoepfel
knoepfel merged commit 350c6ed into main Aug 21, 2026
1 check passed
@knoepfel
knoepfel deleted the cppgsl-dep branch August 21, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants