deps: introduce cppgsl dependency for C++ core guidelines support - #17
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
greenc-FNAL
left a comment
There was a problem hiding this comment.
Is there a particular minimum version of cppgsl required for the features you're currently using?
@greenc-FNAL, I just pushed a change that requires version 4 of cppgsl or greater. PR Framework-R-D/phlex#839 assumes that the installed headers accord with a pattern that was introduced in version 4 (e.g.): - #include <gsl/gsl_pointers> // Before v4
+ #include <gsl/pointers> // v4 and later |
No description provided.