Skip to content

test: cover fixed-hierarchy cursor traversal - #838

Open
knoepfel wants to merge 1 commit into
Framework-R-D:mainfrom
knoepfel:test-data-cell-cursor
Open

test: cover fixed-hierarchy cursor traversal#838
knoepfel wants to merge 1 commit into
Framework-R-D:mainfrom
knoepfel:test-data-cell-cursor

Conversation

@knoepfel

@knoepfel knoepfel commented Aug 21, 2026

Copy link
Copy Markdown
Member

The data_cell_cursor functionality is not unit-tested directly. This PR addresses that.

  • Tests
    • Added unit coverage for data_cell_cursor::fixed_hierarchy.
    • Verified traversal of job, run, and subrun indices in order.
    • Verified cursor copy construction and yielded paths.
    • Added the required resumable-driver utility include.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 99fcfb1c-cf34-470a-a987-60a0bc271da5

📥 Commits

Reviewing files that changed from the base of the PR and between 103df01 and 6ecc7e7.

📒 Files selected for processing (1)
  • test/fixed_hierarchy_test.cpp

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (4)
  • GitHub Check: Analyze cpp with CodeQL
  • GitHub Check: build (gcc, none)
  • GitHub Check: clang-tidy-check
  • GitHub Check: coverage
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{cpp,cc,cxx,h,hpp}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.{cpp,cc,cxx,h,hpp}: Use clang-format tool for all C++ code formatting (VS Code auto-formats on save); configuration defined in .clang-format with 100-character line limit and 2-space indentation
Follow clang-tidy recommendations defined in .clang-tidy

Files:

  • test/fixed_hierarchy_test.cpp
**/*.{hpp,cpp}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{hpp,cpp}: Use .hpp for header files, .cpp for implementation, and *_test.cpp for test files in C++
Enforce 100-character line limit and 2-space indentation in C++ code via .clang-format
Use QualifierAlignment: Right (east-const) style: int const x not const int x in C++
Use PointerAlignment: Left in C++ (pointer * attached to type, not variable name)
All C++ identifiers must use lower_case naming: namespaces, classes, structs, enums, functions, variables, parameters, members, and constants
Exception to C++ naming: template parameters use CamelCase
Exception to C++ naming: macros use UPPER_CASE
Private, protected, and constant members in C++ must have a trailing underscore (_), no trailing underscore on anything else
Use enum class preferred over plain enum in C++
Use std::shared_ptr for shared ownership, std::unique_ptr for exclusive ownership, raw pointers for non-owning references only in C++
Use functors with agent-noun pattern: ModelEvaluator evaluate_model(...) in C++
Apply .clang-tidy checks for bugprone, cert, clang-analyzer, concurrency, cppcoreguidelines, misc, modernize, performance, portability, and readability as defined in the .clang-tidy configuration file
Use phlex:: namespace for core code, phlex::experimental:: for experimental features in C++

Files:

  • test/fixed_hierarchy_test.cpp
🔇 Additional comments (2)
test/fixed_hierarchy_test.cpp (2)

3-3: LGTM!


128-145: LGTM!


📝 Walkthrough

Walkthrough

The test suite now covers copied fixed_hierarchy cursors, nested child traversal, resumable-driver iteration, and yielded hierarchy paths.

Changes

Fixed hierarchy cursor tests

Layer / File(s) Summary
Cursor traversal validation
test/fixed_hierarchy_test.cpp
Adds the resumable_driver include and verifies copied cursors, nested child indices, and yielded /job, /job/run, and /job/run/subrun paths.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 6ecc7

This PR adds focused unit-test coverage without changing product behavior, so no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: aolivier23

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the added test coverage for fixed-hierarchy cursor traversal.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #838      +/-   ##
==========================================
+ Coverage   84.12%   84.19%   +0.06%     
==========================================
  Files         174      174              
  Lines        7402     7402              
  Branches      886      886              
==========================================
+ Hits         6227     6232       +5     
+ Misses        890      885       -5     
  Partials      285      285              
Flag Coverage Δ
scripts 80.09% <ø> (ø)
unittests 86.17% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 103df01...6ecc7e7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant