Repository navigation
Skip Gemma2 SDPA attention tests on transformers 5.21+, keep CI matri… - #12
Open
Rohit7sali wants to merge 1 commit into
Open
Rohit7sali wants to merge 1 commit into
Rohit7sali wants to merge 1 commit into
Conversation
…x running From transformers 5.21, Gemma2Model refuses attn_implementation="sdpa". The attention-conformance tests requested it directly, so the 5 gemma2-sdpa cases failed on Python 3.12 CI (Python 3.10 still installs 5.20.2, where they pass). They now skip when transformers reports the implementation is unsupported; any other loading error still fails, and the Gemma2 eager cases keep covering the family. Library code is unaffected: load_backbone already falls back to eager attention when transformers names attn_implementation in its error. ci.yml: fail-fast: false, so a failure on one Python version no longer cancels the other version's job and hides its result. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From transformers 5.21, Gemma2Model refuses attn_implementation="sdpa". The attention-conformance tests requested it directly, so the 5 gemma2-sdpa cases failed on Python 3.12 CI (Python 3.10 still installs 5.20.2, where they pass). They now skip when transformers reports the implementation is unsupported; any other loading error still fails, and the Gemma2 eager cases keep covering the family.
Library code is unaffected: load_backbone already falls back to eager attention when transformers names attn_implementation in its error.
ci.yml: fail-fast: false, so a failure on one Python version no longer cancels the other version's job and hides its result.