Repository navigation
Pre-release fixes from the developer review (includes #5) - #6
Merged
Merged
Conversation
- train checks its data files before loading any model and names the
exact data split command when recipe data is missing; no output folder
is left behind.
- CLI config errors are one line ("unknown setting train.learning_rate
(did you mean train.lr?)"); an override without = is rejected.
- Exports record the length they were trained on (decision_config
max_length); loaded and served models refuse longer requests unless
max_length / --max-length allows them.
- Every question needs a type, and the server needs a state.
- README: confidence defined; install from GitHub first, PyPI once
published; backbone tests use tiny models, with the real checkpoints
listed; CPU latency and the Decision Index latency rule.
- deciformer15k_qwen3 saves resumable state every 125 steps.
- decisionformer --version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for the review findings agreed before open-sourcing. This branch includes #5 (citation and bidirectional results), so merging this PR covers both.
trainchecks its data files before loading any model and prints the exactdecisionformer data split …command when recipe data is missing. Previously it downloaded the model, then failed with a traceback and left an orphan output folder.error: unknown setting train.learning_rate (did you mean train.lr?). An override without=is rejected instead of silently ignored.decision_config.json(max_length). Loaded and served models refuse longer requests (HTTP 422, never truncated) unlessmax_length=/--max-lengthraises the limit. Previously a 5,088-token request to a model trained on 1,024 tokens was answered silently.type(previously it silently defaulted tochoice), and the server requiresstate.confidence(1 − normalized entropy, not the top probability).deciformer15k_qwen3saves resumable state every 125 steps; with 375 steps and the 500-step default, it never saved before.decisionformer --version.Not included: the fp32 vs bf16 gap between the training metrics and
evalon the export, which needs investigation.Testing: the full suite passes on the GPU box with the GPU hidden. A smoke test of
decisionformer train local_smollm2in an empty folder fails instantly with thedata splitcommand and leaves nothing behind.