Skip to content

refactor: reuse FullingBrand in landing header#191

Merged
Che-Zhu merged 1 commit into
mainfrom
codex/issue-188-shared-fulling-brand
Jul 15, 2026
Merged

refactor: reuse FullingBrand in landing header#191
Che-Zhu merged 1 commit into
mainfrom
codex/issue-188-shared-fulling-brand

Conversation

@Che-Zhu

@Che-Zhu Che-Zhu commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • reuse the shared FullingBrand component in the landing header
  • make the landing wordmark typography (22px size, 24px line height, and -0.5px tracking) canonical across landing, login, and dashboard headers
  • remove the duplicated landing brand markup and obsolete responsive styles
  • add regression coverage for canonical rendering, accessibility, and surface-specific destinations

Why

The landing page duplicated the shared brand lockup introduced for login and dashboard. That component-boundary omission allowed the wordmark typography and responsive behavior to drift between surfaces. Centralizing the lockup keeps brand dimensions and accessible labeling consistent.

Impact

Landing, login, and dashboard now render the same brand treatment. Dashboard retains its /workspace destination; landing and login continue to link to /.

Validation

  • npm test — 40 tests passed
  • npm run lint
  • npm run build
  • git diff --check

Fixes #188

@Che-Zhu Che-Zhu marked this pull request as ready for review July 15, 2026 10:10
@Che-Zhu Che-Zhu merged commit e568b4e into main Jul 15, 2026
1 check passed
@Che-Zhu Che-Zhu deleted the codex/issue-188-shared-fulling-brand branch July 15, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: reuse FullingBrand across landing and login headers

1 participant