Repository navigation
ci(macos): resume notarization polling after network loss - #3413
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 1.0.6 Intel app compiled, was notarized by Apple, and passed Gatekeeper. The DMG then uploaded successfully, but
notarytool submit --waitlost its polling connection (NSURLErrorDomain -1009) and failed the entire job after almost four hours. No verified bundle was uploaded.Separate submission from waiting. Record the submission ID and DMG SHA256, then retry only polling for the observed
-1005/-1009network errors. A retry reuses the same submission and requires an explicit matchingAcceptedresponse. Invalid results, other failures, changed payloads, signature errors, and Gatekeeper rejection still fail. Keep the receipt bound to the stapled DMG's resulting bytes.Retain a seven-day unverified recovery tar archive when Apple verification fails. It preserves executable modes, symlinks, and the submission receipt, and cannot match the normal bundle publication pattern or satisfy the complete release gate. Document this behavior in the existing release guide.
Verification
pnpm run check:github-config: 51 passed, 1 existing pwsh skip.node --test scripts/ci/verify-macos-microphone.test.mjs: 4 passed using real ad-hoc signed fixtures.bash -n scripts/ci/verify-macos-signing.shandgit diff --checkpassed.submit --no-wait --output-format jsonandwait <submission-id> --output-format jsonwith installedxcrun notarytool ... --help; Apple workflow documentation.AI-assisted; focused shell/workflow tests were executed locally. The real Intel rebuild will exercise the Apple service path. No signing or notarization check is bypassed; no product, native mobile, persisted user data, or remote protocol changes. The immutable v1.0.6 source tag remains unchanged.