Repository navigation
fix(diagnostics): default sensitive diagnostics to disabled - #3421
Merged
Merged
Conversation
Sensitive diagnostic payloads are now opt-in rather than enabled by default, preventing accidental exposure of sensitive data in logs. Update the default for include_sensitive_diagnostics to false across Rust and frontend configuration. Co-Authored-By: Jarvis-AI-42 <skyfireitdiy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3213. The settings UI promises that sensitive diagnostics are off by default, but the backend configuration and runtime flags enabled them by default. Sensitive request bodies and frontend event payloads now require an explicit opt-in, including before configuration finishes loading. Saved boolean preferences are preserved.
false.trueandfalsepreferences still take effect after loading.Verification
cargo test --locked --offline -p openbitfun-config-contracts --lib: 101 tests passed.FrontendLogLevelSync, startup privacy, logger, and event batcher tests: 24 tests passed.pnpm run check:web: passed after syncing the latestmainand preparing generated types and Monaco assets.git diff origin/main...HEAD --check: passed.AI-assisted implementation; focused local tests and Web checks completed. No browser automation was used. Live remote workspace, remote control, Peer Device Mode, and Detached Dispatch scenarios were not exercised.
Closes #3213.