Repository navigation
feat(ui): refine model selection, guided setup, and workspace interactions - #3444
Merged
Merged
Conversation
added 4 commits
October 18, 2026 15:28
Keep the grip on the boundary at rest, separate it progressively in the pull direction, and spring back on release. Use a fixed 3px stroke and neutral design-system colors. Add pointer capture, cancellation cleanup, keyboard resizing, and focused interaction coverage while keeping live width updates outside React renders. Validation: 22 focused tests, check:web, motion:audit, Sass compilation, and git diff --check passed. Remote scenarios were not exercised.
Introduce a three-step split-pane creation dialog with concise guidance, validation, and tool loading states. Reuse the application Markdown editor with persistent empty placeholders and automatic rendering of pasted Markdown source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetupWizardwith responsive guidance, content/editor scrolling, accessible headings, and Design Lab examples; use it for three-step Agent creation.Type and Areas
Type: Feature / UI/UX
Areas: Web UI, design system, Design Lab, Markdown editor, localization.
Motivation / Impact
Agent setup now shares a reusable guided layout, model settings are easier to browse and adjust, and navigation/editor interactions provide clearer feedback. Existing host adapters and remote transport paths remain the owners of execution and persistence.
Verification
Passed locally:
pnpm run check:web(type-check, Appearance, typography, theme color and visual contracts).pnpm --dir src/web-ui exec vitest run --maxWorkers=50% src/app/scenes/personal-overview/PersonalOverviewScene.actions.test.tsx src/app/scenes/agents/components/CreateAgentDialog.test.tsx: 31 tests passed after updating overview creation coverage to exercise the real Markdown editor and wizard stages.pnpm run i18n:audit,pnpm run motion:audit, andpnpm --dir src/web-ui run icons:check.git diff --check origin/main...HEADandnode scripts/check-git-object-sizes.mjs --base origin/main --head HEAD.Additional design-system checks expose existing failures in unchanged main-branch contracts: two FlowChat tool-catalog assertions (AgentDelete/AgentInterrupt and Task/AgentControl/ListWorkspaces coverage), and one Design Lab user-bubble background parity assertion. These failures are recorded without weakening their assertions.
Reviewer Notes
AI-assisted; tested with focused automated coverage. Browser/computer-control verification was omitted as requested, so visual fidelity was not manually verified. Remote workspace, Remote Connect, Peer Device Mode, and Detached Dispatch were not exercised against live hosts; local fixtures cover selected surface-switch and stale-response behavior only.
Checklist