Repository navigation
feat(images): add subscription image generation and compact previews - #3554
Merged
Merged
Conversation
kev1n77
force-pushed
the
fmy/imagegen
branch
2 times, most recently
from
October 26, 2026 11:19
88a4637 to
5180e77
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate_imagetool with OpenAI Images, DashScope, and imported Codex/ChatGPT subscription routing, including subscription account identity and system proxy handling.generate-imageskill that uses the configured default image service. Simplify the configuration form and render conversation images as compact, responsive thumbnail galleries with full-size previews.Type and Areas
Type: Feature, bug fix, UI/UX.
Areas: AI adapters, Rust core/runtime, configuration contracts, desktop commands, shared Web UI.
Motivation / Impact
Imported OpenAI subscriptions need their authenticated Codex route rather than the public image-generation endpoint. Users can reuse configured providers, choose a default image model, and generate images without maintaining a second set of generation defaults. Large generated images no longer dominate the conversation.
Verification
pnpm run i18n:auditpassed with zero warnings; localpnpm run build:webpassed.pnpm run check:web— passed, including type checking, Appearance, color, and visual contract gates.pnpm run capabilities:checkpassed;pnpm run capabilities:testpassed all 16 capability and generated-artifact contracts.pnpm run check:core-boundariespassed in an isolated checkout matching the amended commit; all 156 boundary tests passed.tools-image-generationandtools-image-analysisCore checks and materialization tests passed; generation routing tests passed (13), tool-pack tests passed (12), product assembly contracts passed (34), and system-proxy tests passed (7).pnpm run lint:webpassed with zero errors and 14 existing warnings.Full frontend-suite verification comes from Linux CI. The local Windows run also reproduces an overview-dialog timeout on unchanged HEAD; its code was left outside this change. The final thumbnail/configuration changes have DOM/static coverage; their native visual rendering and live SSH workspace, Remote Control, Peer Device, and Detached Dispatch behavior have not been validated.
Reviewer Notes
Image generation has its own
tools-image-generationcompile-time owner and tool feature group. Image inspection retains the narrowtools-image-analysisowner. Desktop/full product, CLI, ACP, and SDK Host explicitly select generation; existing provider IDs and registration order are preserved. System-proxy discovery has an exact registry-only Windows dependency contract.Existing persisted image-service settings, hidden generation parameters, custom endpoints, and authentication identities are preserved. Subscription account pools return an explicit unsupported state. Session-owned image reads stay with the session provider; no controller-local file fallback is introduced.
Checklist