Repository navigation
fix(core): respect permission mode for cards and page publishing - #3561
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Desktop cards with command data sources and Page publishing/deployment requested fresh approval even in Full Access mode. These tools now request fresh approval only in Ask mode; Auto Approve and Full Access proceed without an additional confirmation. Explicit policy denials remain authoritative.
Type and Areas
Type: bug fix
Areas: Rust core tool permissions, desktop cards, Pages
Motivation / Impact
The tools now read the turn's resolved permission mode instead of unconditionally setting
requiresFreshApproval. Ask mode still requires a new decision for each call, including when a policy allow or remembered grant exists. Tool descriptions also direct the agent to use the permission system rather than ask for an extra confirmation after the user has already requested publication.Verification
cargo test --locked -p openbitfun-core --no-default-features --features agent-runtime,git,tools-pages --lib -- presentation_tools_follow_permission_mode desktop_card_tool::tests page_publish_tool::tests page_deploy_tool::tests tool_context_runtime::task_context_testspnpm run fmt:rsandgit diff --check.Reviewer Notes
No persisted fields, protocol shapes, host availability gates, or filesystem routing changed. Unknown/missing mode context keeps the existing interactive fallback, with support for the legacy auto-approve flag. AI-assisted implementation; 32 focused local tests and CI passed. Follow-up review covered mode propagation, legacy fallback, subagent inheritance, policy denials, and remote restrictions; no additional changes were needed.
Checklist