Conversation
sushma-4
requested review from
MelReyCG,
OmarDuran,
bd713,
corbett5 and
rrsettgast
as code owners
July 31, 2026 21:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GEOS build was successful with GCC 13.3.0 on our platform, however two unit tests were failing at runtime with SIGFPE:
testFEMConsistencytestFEMConsistencySo I rebuilt the application few ways:
debugmode - No erros-O2instead of-O3- no errors-gfor debug info:FieldSpecificationEqual::SpecifyFieldValuewhile applying displacement boundary conditions.The failure occurred in:
cpp8if( entries[ j ] >= 0 && entries[ j ] < minDiagonal )Using a temporary diagnostic print, I confirmed that the matrix entry involved in the failing case was finite and negative,
Since this value should not mathematically raise a floating-point exception during the comparison, the issue appears to be specific to the GCC 13.3.0 Release -O3 optimization/code-generation path.
This PR introduces a narrow workaround by materializing the matrix entry into a volatile scalar before performing the comparison using
volatile