feat: Improve linear solvers testing - #4108
Open
victorapm wants to merge 8 commits into
Open
Conversation
victorapm
marked this pull request as ready for review
August 2, 2026 03:44
victorapm
requested review from
MelReyCG,
OmarDuran,
bd713,
cssherman,
dkachuma,
frankfeifan,
herve-gross,
jafranc,
jhuang2601,
joshua-white,
kimtaeho07,
rrsettgast and
tjb-ltk
as code owners
August 2, 2026 03:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds hypre/hypredrive tests to the regression suite. It adds
_mgrsmoke decks covering 25 out of 27 MGR strategies (mostly derived from existing decks by switching their direct solver to gmres+MGR; 25 registered in ATS). Baselines for these tests are always generated byENABLE_HYPREDRV=OFFbuilds, so on a hypredrive-enabled build the same tests double as an equivalence check between the hypredrive and legacy hypre paths.Some additional details:
ats_run_force_legacyCMake target (GEOS_HYPREDRV_FORCE_LEGACY=1re-run against the same baselines), unit tests asserting numerical parity of both pure hypre and hypredrive paths,scripts/compareLinearSolverIterations.pyassert iteration-count parity (so a quality regression with a still-correct answer cannot pass silently)--enable-hypredrv, aGEOS_REQUIRE_HYPREDRVconfigure-time guard, and a hypredrive+legacy double pass in the integrated-tests job)Building these tests surfaced and fixed several real bugs:
SinglePhaseReservoirHybridFVMhad an inverted areWellsShut conditional, applying weak Jacobi relaxation to active well blocks;Known limitations:
singlePhasePoromechanicsConformingFractures,thermalSinglePhasePoromechanicsReservoirFVM) have working decks included but not yet registered, pending cross-path tolerance calibration;Depends on GEOS-DEV/thirdPartyLibs#357