Skip to content

Cache enum .values() #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Caedis merged 1 commit into from
Aug 10, 2026
Merged

Cache enum .values() #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/openblocks/Config.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1273,7 +1273,7 @@ public int getBurnTime(ItemStack fuel) {

if (OpenBlocks.Items.stencil != null) {
if (stencilLoot) {
for (Stencil stencil : Stencil.values()) {
for (Stencil stencil : Stencil.VALUES) {
WeightedRandomChestContent drop = new WeightedRandomChestContent(
new ItemStack(OpenBlocks.Items.stencil, 1, stencil.ordinal()),
1,
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/openblocks/client/gui/GuiDrawingTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public void componentMouseDown(BaseComponent component, int x, int y, int button
(iconDisplay = new GuiComponentSprite(
80,
34,
Stencil.values()[0].getBlockIcon(),
Stencil.VALUES[0].getBlockIcon(),
TextureMap.locationBlocksTexture)).setColor(0f, 0f, 0f).setOverlayMode(true)
.setEnabled(inventorySlots.getSlot(0).getStack() != null);
root.addComponent(iconDisplay);
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/openblocks/common/block/BlockCanvas.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public void registerBlockIcons(IIconRegister registry) {
super.registerBlockIcons(registry);
baseIcon = registry.registerIcon("openblocks:canvas");
wallpaper = registry.registerIcon("openblocks:wallpaper");
for (Stencil stencil : Stencil.values()) stencil.registerBlockIcons(registry);
for (Stencil stencil : Stencil.VALUES) stencil.registerBlockIcons(registry);
}

public void setLayerForRender(int layer) {
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/openblocks/common/item/ItemStencil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@ public int getSpriteNumber() {

@Override
public IIcon getIconFromDamage(int dmg) {
return Objects.firstNonNull(Stencil.values()[dmg].getCoverBlockIcon(), itemIcon);
return Objects.firstNonNull(Stencil.VALUES[dmg].getCoverBlockIcon(), itemIcon);
}

@Override
@SuppressWarnings({ "unchecked", "rawtypes" })
public void getSubItems(Item item, CreativeTabs par2CreativeTabs, List list) {
for (Stencil stencil : Stencil.values()) {
for (Stencil stencil : Stencil.VALUES) {
list.add(new ItemStack(item, 1, stencil.ordinal()));
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/openblocks/common/sync/SyncableBlockLayers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public static Layer createFromStream(DataInput stream) {
layer.setRotation(stream.readByte());
byte b = stream.readByte();
if (b > -1) {
layer.setStencil(Stencil.values()[b]);
layer.setStencil(Stencil.VALUES[b]);
}
layer.setHasStencilCover(stream.readBoolean());
} catch (Exception e) {
Expand Down
Loading