[shironakoushi]

Summary

Transposers upgraded with a GregTech fluid regulator now show the regulator tier in their name, e.g. Transposer (UHV).

• oc:fluidTransferRate is stored as a single long; existing int tags are read unchanged.
• The tier is derived from the transfer rate; rates without a matching tier keep the plain name.

The companion NewHorizonsCoreMod change:

• NewHorizonsCoreMod PR: Align transposer fluid regulator tiers with pump covers NewHorizonsCoreMod#1974
• writes the new fluid regulator rates (matching Give the late game pumps and fluid regulators the same four times rate growth as the conveyors GT5-Unofficial#8215) as a long: 41,943,040 / 167,772,160 / 671,088,640 / 2,684,354,560 / 10,737,418,240 for UHV..UXV;
• Note that although Buff later conveyor speed growth and late pump speed GT5-Unofficial#5538 added an 8x multiplier for some fluid regulators, it did not correspondingly add the 8x multiplier for the transposer, so a reasonable change is definitely needed here.
• switches UXV to 72 mB of Boundless Cosmic Solder;
• registers the tiered transposers as NEI item variants.

Testing

Tested in a GTNH 2.9.0-RC-1 instance:

• Transposers created with the previous version (int oc:fluidTransferRate) were carried over into this build; their rates are preserved and they continue to work. (even if losing their name)

Checklist

• I have tested this PR in DevEnv
• I have tested this PR in Fullpack
• This PR is in compliance with the GTNH AI Policy
• This PR requires another PR in order to merge
  needs Align transposer fluid regulator tiers with pump covers NewHorizonsCoreMod#1974

[Vlamonster]

Thanks for the PRs! I looked them over and have a few suggestions:

• Instead of indexing with 0–10, use the constants from VoltageIndex.
• In the coremod, create the base transposer once as a local variable (not a static field) instead of recreating it for every recipe.
• Move the tier names to the coremod and have it write the tier name into the item's NBT. OpenComputers can then stay generic and only use the new name format when a tier is present in the NBT, so the name mapping in OpenComputers can be removed.
• The base transposer is missing the MV tier name.
• Add .nbtSensitive() to the recipes.

[Vlamonster]

I added one more comment about nbtSensitive. This was something I forgot when I worked on this previously.

[shironakoushi]

I added one more comment about nbtSensitive. This was something I forgot when I worked on this previously.

done

[Vlamonster]

It looks good, so I'll test it in-game again and come back with some final comments :)!

[shironakoushi]

Boundless Cosmic Solder seems too late for UMV, so it remains mutated living solder for UMV transposers

[Vlamonster]

The generic transposer still shows up in NEI next to the tiered variants. This should be removed.

I think you can fix this by using setItemListEntries instead of addItemVariant.

[Vlamonster]

baseTransposer shouldn't be passed as an argument to getTransposer. Right now the caller needs to know how to construct it, which isn't straightforward.

[Vlamonster]

Finally, I think as future work we should add uncrafting recipes for the transposers. This would be a separate PR.

[shironakoushi]

The generic transposer still shows up in NEI next to the tiered variants. This should be removed.

I think you can fix this by using setItemListEntries instead of addItemVariant.

[Vlamonster]

Thanks for the PRs!