Repository navigation
fix(bot): post the version notice in the group when no admin can be reached in private (0.6.1) - #28
Merged
Merged
Conversation
…eached in private (0.6.1)
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 34 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.6.0 announced the new version only in private to the admins. In production, Telegram refused it with 403 "bot can't initiate conversation with a user", because the admin never opened a private chat with the bot. The version was rightly not stored, but every later start would fail the same way, so the notice would never arrive.
Now, when Telegram refuses every private message, the notice goes to the group, the same place it already went when the profile names no admin. The version is stored once any message is taken.
Tests: a new one where an admin can't be reached gets the notice in the group. The failed-send test now fails the group too, so nothing is stored, and the retry reaches the admin. Each behaviour was shown to go red under its own mutation.