Skip to content

fix(bot): post the version notice in the group when no admin can be reached in private (0.6.1) - #28

Merged
GeiserX merged 1 commit into
mainfrom
fix/announce-group-fallback
Oct 19, 2026
Merged

GeiserX merged 1 commit into
mainfrom
fix/announce-group-fallback

Conversation

@GeiserX

@GeiserX GeiserX commented Oct 19, 2026

Copy link
Copy Markdown
Owner

0.6.0 announced the new version only in private to the admins. In production, Telegram refused it with 403 "bot can't initiate conversation with a user", because the admin never opened a private chat with the bot. The version was rightly not stored, but every later start would fail the same way, so the notice would never arrive.

Now, when Telegram refuses every private message, the notice goes to the group, the same place it already went when the profile names no admin. The version is stored once any message is taken.

Tests: a new one where an admin can't be reached gets the notice in the group. The failed-send test now fails the group too, so nothing is stored, and the retry reaches the admin. Each behaviour was shown to go red under its own mutation.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 34 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: GeiserX/SuperCycleTracker/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 35b1f4f6-4d6c-4c3a-bf77-68c6d618a1dc
📥 Commits

Reviewing files that changed from the base of the PR and between c842591 and 82a568e.

📒 Files selected for processing: 4
  • docs/DESIGN.md
  • supercycletracker/__init__.py
  • supercycletracker/bot.py
  • tests/test_bot.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@GeiserX
GeiserX merged commit 520c499 into main Oct 19, 2026
4 checks passed
@GeiserX
GeiserX deleted the fix/announce-group-fallback branch October 19, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant