fix(ui): derive completeness fields and scores from scoring payload - #97
Open
jonathanjasare wants to merge 1 commit into
Open
Conversation
jonathanjasare
marked this pull request as ready for review
August 6, 2026 21:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24.
Summary
completeness_score.category_fields_listinstead of keeping template-owned field lists.Why
The scoring model already builds
category_fields_list,category_details.*.max_points, andmax_scores. The results template duplicated parts of that data, so schema or scoring changes could update backend totals while leaving stale field rows or point totals in the UI.Verification
python -m unittest -v tests.test_result_template: 2 passed.python -m pytest -q -k 'not TestFixtureEndToEnd': 180 applicable tests passed; 3 Torch-dependent fixture tests excluded.ruff check tests/test_result_template.py: passed.python -m compileall -q src tests/test_result_template.py: passed.git diff --check: passed.Scope
Changed only:
src/templates/result.htmltests/test_result_template.pyNo scoring algorithm, schema, dependency, configuration, documentation, or unrelated refactor is included.
Known limitation
Three
TestFixtureEndToEndtests were excluded from the applicable suite because they exercise Torch-dependent fixture processing rather than the changed template path.