Create read only client for connection to penelopedb [Ticket #10] - #32
Closed
chelseakwan wants to merge 8 commits into
Closed
chelseakwan wants to merge 8 commits into
chelseakwan wants to merge 8 commits into
Conversation
TKDPenguin
requested review from
TKDPenguin
and
a lite review from Copilot
and removed request for
Copilot
September 20, 2026 16:00
TKDPenguin
reviewed
Sep 20, 2026
TKDPenguin
left a comment
Collaborator
There was a problem hiding this comment.
Everything looks great for the most part! The only thing is that in your PR description you put N/A under how you tested the code, but you have test_penelope.py. Did you run test_penelope.py? If so, what did it output? Did it seem correct?
Collaborator
|
Yes sorry, we did test it in test_penelope.py. The output seemed correct for get_by_time_bounds and get_by_run_id. Also ran get_all() works, but times out on the full table. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Provide a brief summary of the changes you made and files touched.
Updated client.py to switch from returning lists of Pydantic objects to NumPy 2D arrays, and added cursor-based pagination for pulling large amounts of data.
Technical Description
Added a method of reading data from PenelopeDB so we can write it into OrionDB in the next ticket. Updated the client to return NumPy arrays instead of Pydantic objects and added pagination so pulling the full data table doesn't time out or exhaust memory.
How Has This Been Tested?
Describe your steps for testing this work. Include screenshots or unit test files.
Ran test_penelope.py against the live PenelopeDB. Confirmed get_by_time_bounds and get_by_run_id return correctly-shaped NumPy arrays with real data from the 8/15 test day. We also confirmed get_all_paginated() correctly chunks through the table without timing out.
Ticket Review
Answer the following: