fix(store): preserve verified prompt origin after local deletion - #1535
Merged
dnlrsls merged 1 commit intoSep 29, 2026
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dnlrsls
merged commit Sep 29, 2026
d2647d1
into
Gentleman-Programming:feat/prompt-inbox-foundation-tracker
15 of 16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked Issue
Closes #1458
Child of tracker #1464; merge into
feat/prompt-inbox-foundation-tracker, notmain. This slice does not enable cloud deletes or complete the tracker.🏷️ PR Type
type:bug— Bug fixtype:feature— New featuretype:question— Question requiring tracked worktype:docs— Documentation onlytype:refactor— Code refactoringtype:chore— Maintenancetype:breaking-change— Breaking change📝 Summary
📂 Changes
internal/store/store.gointernal/store/prompt_local_origin_test.godocs/codebase/prompt-inbox-provenance.md256 changed lines; no generated artifacts.
🧪 Test Plan
go test ./internal/store -run 'TestLocalPrompt(Origin|CreationIdentity)' -count=1— PASS (independent verification).go test ./internal/store -count=1— PASS (independent verification).go vet ./internal/store,git diff --check, CRLF-normalizedgofmtcomparison of changed Go files — PASS. Native reviewreview-f620950200b1cd1capproved/acknowledged.🤖 Automated Checks
All GitHub checks pending until they actually run; do not merge if any required check fails.
✅ Contributor Checklist
status:approved).type:*label:type:bug.💬 Notes for Reviewers
Local marker verifies only locally created source under exact stored identity. It cannot authorize registration, a dual-project cloud pair claim or remote deletion; T4b3/T4c remain separate.
alphasession withbetaprompt is intentional. Please inspect the pre-existing tombstone and pulled-live delete tests in particular. Merge by normal merge into #1464 only after CI and substantive review; #1464 stays out of main merge queue.