fix(autosync): pull despite local prompt provenance blocks - #1542
Merged
dnlrsls merged 1 commit intoSep 29, 2026
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dnlrsls
merged commit Sep 29, 2026
1d70f3b
into
Gentleman-Programming:feat/prompt-inbox-foundation-tracker
15 of 16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked Issue
Closes #1458
Follow-up to #1540, based on tracker #1464 at
9411cfc7; merge only tofeat/prompt-inbox-foundation-tracker, notmain.🏷️ PR Type
type:bug— Bug fixtype:feature— New featuretype:question— Question requiring tracked worktype:docs— Documentation onlytype:refactor— Code refactoringtype:chore— Maintenancetype:breaking-change— Breaking change📝 Summary
📂 Changes
internal/cloud/autosync/manager.gointernal/cloud/autosync/manager_test.godocs/codebase/prompt-inbox-provenance.md135 added + 13 removed = 148 changed lines. No cloud verified-delete gate or old/imported-source reauthorization in this slice.
🧪 Test Plan
go test ./internal/cloud/autosync ./cmd/engram ./internal/store -count=1— passed; independent verifier repeated autosync/cmd.go vetfor these packages; gofmt listing andgit diff --check— passed, independent verifier repeated autosync/cmd vet/format/diff.review-51372ffb8f80e83dapproved and acknowledged.🤖 Automated Checks
Pending at PR creation; full GitHub checks must pass before ordinary merge.
✅ Contributor Checklist
type:buglabel.💬 Notes for Reviewers
This addresses the inbound starvation found during independent verification of #1540 without treating uncertain remote registration/claim failures as safe. The existing regression requiring pull to be skipped on a transport push failure remains intact. Tracker #1464 still must not enter the main merge queue: per-source explicit CLI reauthorization (T4b3b), server verified-delete admission (T4c), and integrated validation (T5) remain pending. Idless legacy and cross-project restore constraints are unchanged.