Skip to content

fix(autosync): pull despite local prompt provenance blocks - #1542

Merged
dnlrsls merged 1 commit into
Gentleman-Programming:feat/prompt-inbox-foundation-trackerfrom
dnlrsls:fix/prompt-preflight-pull-progress
Sep 29, 2026
Merged

dnlrsls merged 1 commit into
Gentleman-Programming:feat/prompt-inbox-foundation-trackerfrom
dnlrsls:fix/prompt-preflight-pull-progress

Conversation

@dnlrsls

@dnlrsls dnlrsls commented Sep 29, 2026

Copy link
Copy Markdown
Member

🔗 Linked Issue

Closes #1458

Follow-up to #1540, based on tracker #1464 at 9411cfc7; merge only to feat/prompt-inbox-foundation-tracker, not main.

🏷️ PR Type

  • type:bug — Bug fix
  • type:feature — New feature
  • type:question — Question requiring tracked work
  • type:docs — Documentation only
  • type:refactor — Code refactoring
  • type:chore — Maintenance
  • type:breaking-change — Breaking change

📝 Summary

  • Keep inbound pull progressing when all outbound failures are deterministic local per-entry prompt provenance denials (or existing non-enrollment blocks), without acknowledging or pushing the blocked prompt or reporting a healthy cycle.
  • Store-read errors, remote registration/claim errors, mixed transport failures and cancellation remain fail-closed: they still skip pull and retain failure/backoff. An inbound error supersedes the blocked status truthfully.
  • Regression covers two cycles, cursor advancement without replay, blocked state, no push/ack, uncertain failures and mixed transport error; update codebase documentation.

📂 Changes

File Change
internal/cloud/autosync/manager.go Type only independently known local denials; allow pull on an exclusively safe failure tree while persisting degraded outbound lifecycle.
internal/cloud/autosync/manager_test.go Cycle-level tests for eligible/uncertain/mixed paths and cursor.
docs/codebase/prompt-inbox-provenance.md Note inbound progress and continued remote-delete limitation.

135 added + 13 removed = 148 changed lines. No cloud verified-delete gate or old/imported-source reauthorization in this slice.

🧪 Test Plan

  • Focused cycle regressions — passed.
  • go test ./internal/cloud/autosync ./cmd/engram ./internal/store -count=1 — passed; independent verifier repeated autosync/cmd.
  • go vet for these packages; gofmt listing and git diff --check — passed, independent verifier repeated autosync/cmd vet/format/diff.
  • Independent verifier initially identified a critical classification error in the first draft; corrected before commit and reverified without blocking findings.
  • Native review review-51372ffb8f80e83d approved and acknowledged.
  • GitHub CI/policy checks pending.

🤖 Automated Checks

Pending at PR creation; full GitHub checks must pass before ordinary merge.

✅ Contributor Checklist

💬 Notes for Reviewers

This addresses the inbound starvation found during independent verification of #1540 without treating uncertain remote registration/claim failures as safe. The existing regression requiring pull to be skipped on a transport push failure remains intact. Tracker #1464 still must not enter the main merge queue: per-source explicit CLI reauthorization (T4b3b), server verified-delete admission (T4c), and integrated validation (T5) remain pending. Idless legacy and cross-project restore constraints are unchanged.

@dnlrsls dnlrsls added the type:bug Bug fix label Sep 29, 2026
@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 0239e97f-ddab-4b91-93a2-ac1c2f672742

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dnlrsls
dnlrsls merged commit 1d70f3b into Gentleman-Programming:feat/prompt-inbox-foundation-tracker Sep 29, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant