feat(cloudserver): authorize explicit prompt source attestations - #1548
Merged
dnlrsls merged 1 commit intoSep 29, 2026
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dnlrsls
merged commit Sep 29, 2026
bd126db
into
Gentleman-Programming:feat/prompt-inbox-foundation-tracker
15 of 16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked Issue
Closes #1458
Third bounded child for explicit source reauthorization, based on open tracker #1464 at
aee38de0, not main.🏷️ PR Type
type:feature— New feature📝 Summary
POST /sync/prompt-source-attestations, with strict bounded request, actor bound to the authenticated principal, and current grants on both asserted owner and prompt projects before accessing a global session identity.📂 Changes
internal/cloud/cloudserver/cloudserver.gowithAuth.internal/cloud/cloudserver/prompt_source_attestation.gointernal/cloud/cloudserver/prompt_source_attestation_test.godocs/codebase/prompt-inbox-provenance.md257 additions, 2 deletions. Partial remote registration/claim may persist if later audit insert fails; client sees failure and MUST NOT record local confirmation. Retry is idempotent for the binding and appends audit only on success.
🧪 Test Plan
withAuthreturned 401, expectation corrected before commit.go test ./internal/cloud/cloudserver -run '^TestPromptSourceAttestation(BearerBoundary|Admission)$' -count=1— PASS (independent verifier).go test ./internal/cloud/cloudserver -count=1— PASS (independent verifier).go vet ./internal/cloud/cloudserver, gofmt listing for new files,git diff --cached --check— PASS. Storage-only exact-binding/append-only tests passed against disposable Postgres in preceding feat(cloudstore): record explicit prompt source attestations #1547; HTTP-to-Postgres path not yet verified. Native reviewreview-59f121b5698420ccapproved/acknowledged; nonblocking reliability advisory on fake-store identity assertions to revisit in integration tests.🤖 Automated Checks
CI pending. All required checks must pass before normal merge.
✅ Contributor Checklist
type:featurelabel.💬 Notes for Reviewers
A confirmed human assertion plus current grants can authorize a cloud binding even for a formerly unregistered imported source; it never proves local creation. This route does not itself authorize autosync or any remote delete. Subsequent children need a local confirmed marker, one-source CLI with preview/confirmation, gated autosync, separate verified-delete policy and integrated validation before #1464 can be queued.