Skip to content

fix(odd-phase): label CI status polling as checking - #1512

Merged
Alan-TheGentleman merged 1 commit into
mainfrom
fix/odd-phase-ci-watch-checking
Sep 27, 2026
Merged

Alan-TheGentleman merged 1 commit into
mainfrom
fix/odd-phase-ci-watch-checking

Conversation

@Alan-TheGentleman

@Alan-TheGentleman Alan-TheGentleman commented Sep 27, 2026 •

Copy link
Copy Markdown
Collaborator

PR type

  • Bug fix (type:bug)

Summary

The Gentle Shell working label showed exploring while the agent was waiting on CI (for example sleep 30; gh pr checks 1511 --watch | tail), because gh pr checks and gh run * were classified as read-only inspection.

  • gh pr checks and gh run view|watch|list now infer checking.
  • gh pr|issue|repo|release view|list|diff|status still infer exploring.
  • Other gh run subcommands (for example rerun, cancel) now leave the label unchanged instead of reading as exploration.

Verification

  • Test-first: the new CI-polling case was observed RED (exploring), then GREEN.
  • node --experimental-strip-types --test tests/odd-phase-inference.test.ts tests/odd-phase.test.ts: 48/48 passed.
  • node scripts/check-types.mjs: 188 baseline diagnostics, no regressions.
  • node scripts/build-runtime-modules.mjs --check: generated modules match sources.
  • Native review: medium/reliability approved and acknowledged.

Summary by CodeRabbit

  • Improvements
    • GitHub CI status and run commands are now categorized as checking, while pull request and issue browsing commands remain categorized as exploring.

gh pr checks and gh run view/watch/list verify work, so they infer checking instead of exploring.
@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 0191b14d-a2ff-47bc-a131-9cbf653ea853

📥 Commits

Reviewing files that changed from the base of the PR and between 78775c3 and a735c44.

📒 Files selected for processing (2)
  • lib/odd-phase-inference.ts
  • tests/odd-phase-inference.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

GitHub pull request checks and run view, watch, and list commands now infer the checking phase. Tests cover these commands and confirm that pull request and issue inspection commands infer the exploring phase.

Changes

GitHub command phase inference

Layer / File(s) Summary
Classify GitHub commands
lib/odd-phase-inference.ts, tests/odd-phase-inference.test.ts
Checking rules now include gh pr checks and gh run view, watch, and list. The exploration rule no longer includes run or checks. Tests cover the checking and exploring classifications.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to a735c

The change limits checking labels to the intended CI status commands; other run commands retain their prior behavior. No material merge risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: classifying CI status polling as checking.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Alan-TheGentleman
Alan-TheGentleman merged commit b27bd32 into main Sep 27, 2026
6 checks passed
@Alan-TheGentleman
Alan-TheGentleman deleted the fix/odd-phase-ci-watch-checking branch September 27, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant