Repository navigation
docs(sensor): the compose header says make up, and that fenrir is built - #1162
Merged
Merged
Conversation
The header still said "NOT `make up STACK=sensor`", because the stack had no secrets, and that fenrir was "NOT BUILT YET". Both stopped being true. #834 gave Alloy an ingest token that `make up` renders from secrets/sensor.sops.yaml, as the stack's README and the INGEST_TOKEN line further down this file already say. fenrir was built on 2026-09-30, and #437's reboot proof passed. Comment only; no service definition changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Gerrrt
force-pushed
the
gerrrt/sensor-header-make-up
branch
from
October 10, 2026 21:23
edc51dd to
384e515
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The header incorrectly identifies the runbook, rather than the changelog, as containing the completed reboot proof.
1 open finding
What changed in this PR
Updates the sensor stack header to reflect fenrir’s deployed state and current secret-aware deployment workflow.
Changes:
- Marks fenrir as built.
- Replaces direct Compose instructions with
make up STACK=sensor.
| File | Description |
|---|---|
stacks/sensor/compose.yaml |
Corrects deployment and host-status comments. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…ts result Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Gerrrt
enabled auto-merge (squash)
October 10, 2026 21:47
Gerrrt
disabled auto-merge
October 10, 2026 21:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header of
stacks/sensor/compose.yamlhad two claims that stopped being true:make up STACK=sensor", on the grounds that the stack has no secrets. Since The lab Prometheus and Loki take unauthenticated writes, /-/quit and log deletion from the whole of VLAN 30 #834 it has one: Alloy's token for the lab's ingest proxy, whichmake uprenders fromsecrets/sensor.sops.yaml.stacks/sensor/README.mdand theINGEST_TOKENline further down the same file already say so. The header now saysmake up STACK=sensor, and points to the README for the one-timesecrets-initandsecrets-editsteps.build-the-sensor-guest.md, and Run Zeek on a mirror port, and see the VLAN 30 traffic the firewall never will #437's reboot proof passed.This is a comment-only change, so
make uprecreates nothing.Found while writing the
make upcommands for the socket-proxy rollout (#1156), where the header and the README disagreed.🤖 Generated with Claude Code