Repository navigation
docs(hardware): record the CRS326's management MAC as an OUI, like every other - #1186
Merged
Merged
Conversation
…ery other docs/security.md says full MACs are withheld and truncated to the OUI, and every other MAC in hardware.md and network.md is. The CRS326's bench reading on 2026-10-05 carried the full six octets. The serial stays: hardware.md is the inventory of record for serials, and that is a different decision from the one on MACs. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Dchg9vmfKeQd7uzRzPcLR
There was a problem hiding this comment.
🟢 Approval recommended
The documentation-only change consistently applies the established MAC-address policy.
0 open findings
What changed in this PR
Updates the CRS326 inventory entry to follow the repository’s MAC-address privacy policy.
Changes:
- Replaces the full management MAC with its OUI.
- Clarifies why the address is truncated.
| File | Description |
|---|---|
docs/hardware.md |
Truncates the CRS326 management MAC to its OUI. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
One line in
docs/hardware.md: the CRS326's management MAC, read at the bench on 2026-10-05, is now48:8f:5a:xx:xx:xxrather than its full six octets. Nothing else in the entry moves; the serial stays, becausehardware.mdis the inventory of record for serials and that is a separate decision from the one on MACs.Why
Found during a repository review.
docs/security.md§ What this repository deliberately does not publish says full MACs are truncated to the OUI, and every other MAC inhardware.mdandnetwork.mdis. This was the one exception. The only full MAC left in the tree is the LLDP multicast constant in the Suricata runbook, which identifies a protocol, not a device.Blast radius
None. Documentation only.
secrets/*.sops.yamlVerification
grepfor a six-octet MAC acrossdocs/andREADME.mdnow finds nothing but the LLDP constant.make validatecould not be run in this environment (no Docker daemon); CI's markdownlint andcheck_docs.pycover it.make validatepasses (CI)🤖 Generated with Claude Code
https://claude.ai/code/session_013Dchg9vmfKeQd7uzRzPcLR
Generated by Claude Code