[sirpy]

Description

Switch wallet to viem with fallback rpcs from chainlist use @goodwidget/core createviemfallbackclient

Summary by Sourcery

Migrate blockchain wallet operations from Web3 to viem with resilient RPC fallbacks while preserving local and KMS transaction workflows.

New Features:

• Replace wallet blockchain clients with viem and GoodWidget fallback clients, using configured RPCs with Chainlist discovery as fallbacks.
• Support viem-based contract reads, transaction encoding, native transfers, receipt handling, and local or KMS transaction signing.

Bug Fixes:

• Improve transaction error normalization, nonce queue recovery, timeout handling, and reverted-transaction detection.

Enhancements:

• Update blockchain configuration and wallet integrations to use viem clients, bigint-compatible values, and viem contract interfaces.
• Remove obsolete staking and fishing task implementations and their related administrative endpoint and configuration.
• Update wallet, verification, and GoodID integrations for viem contract and account representations.

Build:

• Add viem and @goodwidget/core dependencies and update the lockfile.

Documentation:

• Document viem wallet clients, RPC fallback behavior, contract usage, and isolated wallet test execution.

Tests:

• Add comprehensive viem wallet coverage for fallback RPC creation, transaction submission, KMS signing, nonce handling, bigint values, and reverted transactions.
• Migrate wallet tests from Web3 APIs to viem APIs and remove obsolete staking-related tests.

[sourcery-ai]

Sorry @sirpy, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 1 day and 1 hour by commenting @sourcery-ai review. Upgrade to get a review now.

[Copilot]

🟡 Changes recommended

Unbounded retries on insufficient funds can stall staking operations, while unsafe post-broadcast lock release can corrupt nonce reservations and allow duplicate-nonce submissions.

7 open issues

• Avoid resetting nonce queue after releasing the lock · New
• Stop retrying unchanged insufficient-funds transactions · New
• Honor configured WebSocket providers when creating clients · New
• Recognize viem receipt timeouts in staking recovery · New
• Normalize bigint fields in returned receipts · New
• Convert decoded event count before slicing · New
• Treat missing transaction receipts as retryable · New

What changed in this PR

Migrates the server’s blockchain wallet infrastructure from Web3.js to viem, using GoodWidget’s fallback clients while retaining KMS signing and queued transaction workflows.

Changes:

• Adds configurable HTTP RPC fallbacks and Chainlist discovery.
• Migrates wallet, contract, staking, and event operations to viem APIs.
• Updates transaction handling, tests, documentation, dependencies, and lint rules.

File	Description
src/​server/​verification/​verificationAPI.js	Uses viem contract addresses and expands request logging.
src/​server/​utils/​helpers.js	Applies formatting-only changes.
src/​server/​storage/​cron/​CleanupAbandonedSignups.js	Reformats the cleanup query without changing behavior.
src/​server/​goodid/​veramo.js	Retrieves signing accounts from the migrated wallet model.
src/​server/​blockchain/​Web3Wallet.js	Implements viem clients, contract operations, and transaction submission.
src/​server/​blockchain/​stakingModelTasksV2.js	Migrates staking and fishing operations to viem.
src/​server/​blockchain/​stakingModelTasksOld.js	Migrates legacy staking and fishing operations to viem.
src/​server/​blockchain/​MultiWallet.js	Uses viem contract addresses for chain filtering.
src/​server/​blockchain/​BaseAdminWallet.js	Migrates faucet setup and reads to viem.
src/​server/​blockchain/​AdminWallet.js	Migrates mainnet clients and transaction handling.
src/​server/​blockchain/​__tests__/​viemWallet.test.js	Adds fallback, signing, receipt, and nonce tests.
src/​server/​blockchain/​__tests__/​stakingModelManager.test.js	Updates staking tests for viem interfaces.
src/​server/​blockchain/​__tests__/​fishManager.test.js	Updates fishing tests for viem interfaces.
src/​server/​blockchain/​__tests__/​baseWallet.test.js	Updates contract-address assertions.
src/​server/​blockchain/​__tests__/​adminWalletKMS.test.js	Migrates KMS transaction checks and removes the custom WETH test.
src/​server/​blockchain/​__tests__/​adminWallet.test.js	Updates wallet reads and bigint assertions.
README.md	Documents viem usage, RPC behavior, and wallet testing.
package.json	Adds viem and GoodWidget dependencies.
.eslintrc	Adjusts import validation for the new dependencies.

_{Review effort: Balanced}