feat(dataplex): add global data quality scan sample#14327
Conversation
- Add new `data_quality_scan_global.py` sample demonstrating how to create a global data quality scan - Add `requirements.txt` for the new sample
product-auto-label
Bot
added
api: dataplex
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new Python script to create a Dataplex Data Quality Scan using global API endpoint routing, along with its dependency requirements. Feedback on the changes highlights a SQL syntax error due to a missing space in the concatenated query string, and a return type mismatch caused by catching exceptions and implicitly returning None instead of the annotated DataScan type.
|
The sample is working locally: 
Data scan is created successfully and visible on GCP Web Interface. 
|
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
amcolin
left a comment
amcolin
left a comment
There was a problem hiding this comment.
Including this sample within the snippets directory instead of creating a new folder seems ideal. Additionally, renaming it to create_data_quality_scan_global.py would ensure consistency with the existing patterns in this repository and avoid conflicts with the operations we are planning to add.
| dataset_id: str, | ||
| table_id: str, | ||
| location: str, | ||
| column_id_1: str, |
There was a problem hiding this comment.
Are these column IDs required, or is it possible to omit them from the parameters?
There was a problem hiding this comment.
This sample expects a bigquery table with at least 2 columns, with names provided by the user.
There was a problem hiding this comment.
can you update the description to include the arguments and expectations? Thanks.
There was a problem hiding this comment.
Hello, i've added proper docs to the method with attribute despritions.
5 participants
Description
data_quality_scan_global.pysample demonstrating how to create a global data quality scanrequirements.txtfor the new sampleFixes b/524660077
Checklist
Testing
Compliance & Style
Post-Approval Actions