BE006: Recommendation Candidate Retrieval Validation and Automated Tests - #198
Open
shshwtsuthar wants to merge 1 commit into
Open
BE006: Recommendation Candidate Retrieval Validation and Automated Tests#198shshwtsuthar wants to merge 1 commit into
shshwtsuthar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Description
Productcontract, including a document-ID barcode fallback.Validation
npx jest __tests__/recommendationCandidateRetrieval.test.ts __tests__/recommendationsAllergenSafety.test.ts __tests__/getProductById.test.ts --runInBandFull-suite note
npm test -- --runInBandreaches the new candidate suite successfully but has two pre-existing unrelated failures onmain: missing@firebase/rules-unit-testing/Node typings instorage.rules.test.ts, and staleshoppingCartApi.test.tserror-envelope assertions. This PR does not touch those files.Checks