Skip to content

format.h doesn't handle char* correctly #32

Description

@jrabinow
char *foobar = "lorem ipsum";
format("dolor sit {1} amet", foobar);

Expected result:
"dolor sit lorem ipsum amet"

Actual result:
"dolor sit dolor sit amet amet"

When passing in a char*-type variable to format's varargs list, need to cast the variable to std::string or convert it to a std::string. Not doing so results in fmt variable (first arg) being read a second time as one of the vararg variables.

Not a major issue but this small wart can take people by surprise - if this is wontfix, may I recommend adding a comment in the source?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions