Conversation
install() rules are cumulative across a CMake project, so projects that include libshared via add_subdirectory() (e.g. Timewarrior since GothenburgBitFactory/timewarrior#706) inherit the rules installing lib/libshared.a and all headers to include/, polluting the embedding project's install manifest. Guard the install rules with LIBSHARED_IS_TOP_LEVEL, which is set when libshared is the top-level project, so they only apply to standalone builds. Closes #122 Signed-off-by: Thomas Lauf <thomas.lauf@tngtech.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install() rules are cumulative across a CMake project, so projects that include libshared via
add_subdirectory()(e.g. Timewarrior since GothenburgBitFactory/timewarrior#706) inherit the rules installinglib/libshared.aand all headers toinclude/, polluting the embedding project's install manifest.Guard the install rules with
LIBSHARED_IS_TOP_LEVEL, which is set when libshared is the top-level project, so they only apply to standalone builds.Closes #122