Fix blocked conversation playing notification - #203
Merged
thestinger merged 1 commit intoJul 30, 2026
Conversation
m4pl
marked this pull request as ready for review
July 14, 2026 10:14
RankoR
suggested changes
Jul 20, 2026
RankoR
left a comment
RankoR
left a comment
Contributor
There was a problem hiding this comment.
It seems to be executed only if MessageNotificationState.getNotificationState() returns null (BugleNotifications.java:157). Non-null will bypass it.
It would be also nice to have tests for it.
m4pl
force-pushed
the
task/82-block-notification-sounds
branch
from
July 21, 2026 10:26
142388d to
c5b92a6
Compare
m4pl
force-pushed
the
task/82-block-notification-sounds
branch
from
July 21, 2026 20:54
c5b92a6 to
ea8b0f9
Compare
m4pl
force-pushed
the
task/82-block-notification-sounds
branch
from
July 21, 2026 20:57
ea8b0f9 to
573c5ea
Compare
sdsantos
approved these changes
Jul 28, 2026
sdsantos
left a comment
sdsantos
left a comment
There was a problem hiding this comment.
I have been able to reproduce the issue and the changes fixed it.
Code looks good to me.
RankoR
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #82
This only reproduces while the blocked conversation itself is open on screen. On the list or in the background the observable soft-sound path no longer fires.