Add warning that SMS is not secure in onboarding - #218
Merged
Conversation
m4pl
force-pushed
the
task/47-sms-not-safe-warning
branch
from
July 16, 2026 14:17
2a7b0ae to
3886839
Compare
m4pl
marked this pull request as ready for review
July 21, 2026 09:31
sdsantos
approved these changes
Jul 28, 2026
sdsantos
left a comment
sdsantos
left a comment
There was a problem hiding this comment.
Code looks good and the features works correctly.
I feel that showing the screen on every versionCode change is bit too bothersome, but maybe that's the intended goal here.
Member
|
Showing it again after each update would likely be excessive. |
m4pl
force-pushed
the
task/47-sms-not-safe-warning
branch
from
July 29, 2026 21:53
3886839 to
bec8ab8
Compare
RankoR
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47