Add object examines for a lot of the "most placed" objects - #1290
Open
trunksbomb wants to merge 1 commit into
Open
Add object examines for a lot of the "most placed" objects#1290trunksbomb wants to merge 1 commit into
trunksbomb wants to merge 1 commit into
Conversation
…aced" objects (those with 75 or more placements). The reference is a Rune Server thread which is linked in `all_scraped.objs.toml`, where a user scraped examines from live RS2 servers in 2021. This commit adds examine texts for 135 unique objects, representing a total of 40,360 object placements in-world, as well as updating a few other commonly-placed objects that already had definitions in a `objs.toml` file but no examine text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add manually cross-referenced examine texts for a lot of the "most placed" objects (those with 75 or more placements). The reference is a Rune Server thread which is linked in
all_scraped.objs.toml, where a user scraped examines from live RS2 servers in 2021. This commit adds examine texts for 135 unique objects, representing a total of 40,360 object placements in-world, as well as updating a few other commonly-placed objects that already had definitions in aobjs.tomlfile but no examine text.Honestly it's mostly trees and wheat, but hey now they have descriptions.