Repository navigation
Conversation
Collaborator
|
Thanks for contributing! Sorry for letting you wait. Holidays and higher priority product work delayed the review of your PR. We'll take a look. |
uklotzde
reviewed
Jan 12, 2026
uklotzde
left a comment
uklotzde
left a comment
Collaborator
There was a problem hiding this comment.
Only some minor remarks from my side.
Collaborator
|
We also need a changelog entry. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nmammeri
force-pushed
the
feat/add-translate-browse-path-service
branch
from
October 5, 2026 22:36
1176032 to
5406564
Compare
- Add TODO about returning non-owned results, consistent with other responses. - Implement translate_browse_path() via translate_many_browse_paths(). - Use turbofish with collect(). - Use sentence-style line comments in example. - Stop checking hard-coded node IDs in example, they change on the demo server. - Add changelog entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
I rebased onto main and also changed the example to stop checking hard-coded node IDs. The demo server changed the ID for CoffeeBeanLevel, so the example now just prints the IDs it gets back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.