chore: run tests with ASAN in CI by cartercanedy · Pull Request #360 · HMIProject/open62541

cartercanedy · 2026-10-12T16:54:01Z

Closes #358

Summary

create a new justfile recipe that runs tests with ASAN enabled
add a concurrent CI job that runs ASAN as a required CI step
pins the MacOS LLVM toolchain instance to the homebrew installation
- prevents runtime ASAN symbol version mismatches, since the symbols from apple's 1st-party llvm distribution don't match the rust-bundled version.

NOTE: stacked on top of #356, needs to be rebased before merge

uklotzde · 2026-10-17T10:03:46Z

Stacked PRs might not work (yet) with forked repositories. Marking this as Draft until #356 has been merged.

uklotzde · 2026-10-21T23:03:28Z

I tried to merge main. But there are still differences. Please rebase.

…atch at link time

uklotzde · 2026-10-22T08:12:14Z

A first local test on Linux/Fedora failed.

  CMake Error at /usr/share/cmake/Modules/CMakeTestCCompiler.cmake:67 (message):
    The C compiler

      "/usr/lib64/ccache/cc"

    is not able to compile a simple test program.

    It fails with the following output:

      Change Dir: '/home/uk/github/rust/open62541/target/x86_64-unknown-linux-gnu/debug/build/open62541-sys/ca4d013612b2c8ad/out/build/CMakeFiles/CMakeScratch/TryCompile-t6h3Bk'
      
      Run Build Command(s): /usr/bin/cmake -E env VERBOSE=1 /usr/bin/gmake -f Makefile cmTC_dbe94/fast
      /usr/bin/gmake  -f CMakeFiles/cmTC_dbe94.dir/build.make CMakeFiles/cmTC_dbe94.dir/build
      gmake[1]: Entering directory '/run/media/uk/Build/cargo/open62541/target/x86_64-unknown-linux-gnu/debug/build/open62541-sys/ca4d013612b2c8ad/out/build/CMakeFiles/CMakeScratch/TryCompile-t6h3Bk'
      Building C object CMakeFiles/cmTC_dbe94.dir/testCCompiler.c.o
      /usr/lib64/ccache/cc   -fsanitize=address -fno-omit-frame-pointer -ffunction-sections -fdata-sections -fPIC -m64 -fsanitize=address -w  -o CMakeFiles/cmTC_dbe94.dir/testCCompiler.c.o -c /home/uk/github/rust/open62541/target/x86_64-unknown-linux-gnu/debug/build/open62541-sys/ca4d013612b2c8ad/out/build/CMakeFiles/CMakeScratch/TryCompile-t6h3Bk/testCCompiler.c
      Linking C executable cmTC_dbe94
      /usr/bin/cmake -E cmake_link_script CMakeFiles/cmTC_dbe94.dir/link.txt --verbose=1
      /usr/bin/ld.bfd: cannot find /usr/lib64/libasan.so.8.0.0: No such file or directory
      collect2: error: ld returned 1 exit status
      /usr/lib64/ccache/cc  -fsanitize=address -fno-omit-frame-pointer -ffunction-sections -fdata-sections -fPIC -m64 -fsanitize=address -w  CMakeFiles/cmTC_dbe94.dir/testCCompiler.c.o -o cmTC_dbe94
      gmake[1]: *** [CMakeFiles/cmTC_dbe94.dir/build.make:102: cmTC_dbe94] Error 1
      gmake[1]: Leaving directory '/run/media/uk/Build/cargo/open62541/target/x86_64-unknown-linux-gnu/debug/build/open62541-sys/ca4d013612b2c8ad/out/build/CMakeFiles/CMakeScratch/TryCompile-t6h3Bk'
      gmake: *** [Makefile:134: cmTC_dbe94/fast] Error 2

Update: Probably, because cc points to gcc.

uklotzde · 2026-10-22T08:20:56Z

Run on CI succeeded: https://github.com/uklotzde/open62541/actions/runs/39746865588

Copilot

🟡 Changes recommended

The ASAN CI matrix can test an unintended target, and unpinned LLVM/nightly versions can cause required-job failures.

1 open issue

Matrix target is not enforced by the ASAN test · New

What changed in this PR

Adds AddressSanitizer test coverage for Rust tests and integrates native Linux/macOS ASAN jobs into CI.

Changes:

Adds nightly ASAN test recipes with leak detection.
Adds Linux and macOS ASAN CI matrix jobs.
Updates the array ownership test to transfer raw allocation ownership safely.

File	Description	Review findings
`src/ua/array.rs`	Updates the raw-array test to use move-based ownership transfer.	No unresolved findings.
`.justfile`	Defines reusable nightly ASAN test and command recipes.	No unresolved findings.
`.github/workflows/test.yaml`	Adds Linux/macOS ASAN jobs and macOS LLVM configuration.	The matrix target is not enforced by the test recipe; the LLVM/nightly pairing is not pinned or verified; and required-check configuration may still need repository-level updates.

_{Review effort: Lite}

cartercanedy · 2026-10-23T19:13:00Z

+    steps:
+      - name: Install Rust toolchain
+        # Sanitizers are only available on nightly Rust.
+        uses: dtolnay/rust-toolchain@nightly


I feel like this is going to be a complete noop practically. If the target triple is set to something else other than the system's target triple, it's either going to run fine (e.g. x86_64-linux-unknown-musl vs -gnu) or it's going to have an incompatible ABI and running it is going to fail

@sgoll Thoughts?

I don't think the extra verification is necessary. All the other cargo commands inside our CI workflows don't run such a check either. matrix.target is only ever used to set up the toolchain itself. Therefore, the current change (without this check) is fine, and cargo takes the toolchain's target itself—just as it does in the other steps and jobs.

Closes #348 Implements `UA_RelativePath` factories/methods: - `UA_RelativePath_parse` -> `ua::RelativePath::parse() -> Result<Self>` - `UA_RelativePath_print` -> `impl Display for ua::RelativePath` - `get`/`get_mut` that folds the fallible access into the array validity check - `iter`/`iter_mut` that also maps invalid array access to an empty iterator - ~`Index`/`IndexMut` for unsafe element access~ initially implemented, but removed since unsafe to reinforce safe access semantics Accesser methods were also implemented. _Note: rebased this onto the stack above #360 to unblock downstream work_ --------- Co-authored-by: Uwe Klotz <uwe.klotz@gmail.com>

sgoll · 2026-11-03T14:13:33Z

+          - target: aarch64-apple-darwin
+            runner_os: macos-15
+
+          - target: x86_64-unknown-linux-gnu
+            runner_os: ubuntu-24.04


Should we switch to macos-26 and ubuntu-26.04 after the merge of #365?

How about using -latest for both runner_os?

That would move the new check to latest-dependencies.yaml. I don't think that's the right spot, though, because that workflow specifically checks whether the library still builds on the latest CI environments and dependencies (running cargo update first), thus mixing the two cases.

So, I'd continue to use fixed versions in test.yaml, to prevent sudden unexpected failures in the CI due to newly-released runner environments.

Then we should add a comment to keep the runners pinned at the latest available image, currently macos-26 and ubuntu-26.04.

sgoll · 2026-11-03T14:31:44Z

+    steps:
+      - name: Install Rust toolchain
+        # Sanitizers are only available on nightly Rust.
+        uses: dtolnay/rust-toolchain@nightly


I don't think the extra verification is necessary. All the other cargo commands inside our CI workflows don't run such a check either. matrix.target is only ever used to set up the toolchain itself. Therefore, the current change (without this check) is fine, and cargo takes the toolchain's target itself—just as it does in the other steps and jobs.

cartercanedy force-pushed the cc/asan branch 3 times, most recently from 09f43d2 to 103ce7c Compare October 14, 2026 12:37

cartercanedy mentioned this pull request Oct 14, 2026

feat(path): expose *Path-related utility functions #349

Merged

cartercanedy force-pushed the cc/asan branch from 103ce7c to e01b242 Compare October 15, 2026 19:12

uklotzde marked this pull request as draft October 17, 2026 10:02

uklotzde added this to the v0.12.1 milestone Oct 17, 2026

cartercanedy force-pushed the cc/asan branch 2 times, most recently from a6c712d to f7095e4 Compare October 20, 2026 12:10

cartercanedy mentioned this pull request Oct 20, 2026

fix: memory leak in ua::Array::move_into_raw #356

Merged

cartercanedy force-pushed the cc/asan branch 2 times, most recently from 390a82f to 72ddf19 Compare October 21, 2026 21:03

cartercanedy added 4 commits October 21, 2026 22:55

add justfile recipe to run asan tests and fix existing leak

3fc95cb

add asan CI job

a4f33f7

pin CC toolchain on macOS builds to mitigate ASAN symbol version mism…

5cb7b84

…atch at link time

set --cfg asan in the test-asan recipe

843a54c

cartercanedy force-pushed the cc/asan branch from 089ec07 to 843a54c Compare October 22, 2026 03:57

uklotzde marked this pull request as ready for review October 22, 2026 08:02

uklotzde requested a review from sgoll October 22, 2026 08:06

uklotzde marked this pull request as draft October 22, 2026 08:12

uklotzde modified the milestones: v0.12.1, v0.12.2 Oct 22, 2026

uklotzde marked this pull request as ready for review October 22, 2026 08:38

uklotzde requested a lite review from Copilot October 22, 2026 08:39

Copilot started reviewing on behalf of uklotzde October 22, 2026 08:40

View session

Copilot AI reviewed Oct 22, 2026

View reviewed changes

sgoll reviewed Nov 3, 2026

View reviewed changes

Conversation

cartercanedy commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

uklotzde commented Oct 17, 2026

Uh oh!

uklotzde commented Oct 21, 2026

Uh oh!

uklotzde commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

uklotzde commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

cartercanedy Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

uklotzde Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sgoll Nov 3, 2026

Choose a reason for hiding this comment

Uh oh!

sgoll Nov 3, 2026

Choose a reason for hiding this comment

Uh oh!

uklotzde Nov 3, 2026

Choose a reason for hiding this comment

Uh oh!

sgoll Nov 4, 2026

Choose a reason for hiding this comment

Uh oh!

uklotzde Nov 4, 2026

Choose a reason for hiding this comment

Uh oh!

sgoll Nov 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cartercanedy commented Oct 12, 2026 •

edited

Loading

uklotzde commented Oct 22, 2026 •

edited

Loading

uklotzde commented Oct 22, 2026 •

edited

Loading

uklotzde Oct 26, 2026 •

edited

Loading