Repository navigation
fix(tickets): preserve account state during inactive credential refresh - #190
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
292 harvesting now admits disabled/error OpenAI OAuth accounts, but the shared OAuth refresh path still skipped their expired credentials and could overwrite account status when the refresh token was missing.
Mark ticket credential requests with a private context value. Only eligible OpenAI ticket accounts may refresh while inactive through this path; expired credentials without a refresh token return a ticket authentication failure without quarantining or changing the account. Ordinary inference retains its existing inactive-account and missing-refresh-token protections. Setup Token behavior remains unchanged.
Focused synthetic tests cover inactive credential refresh, unchanged account status/schedulability/error text, no upstream ticket request on invalid credentials, and preservation of ordinary inference protections. This completes the status-independent ticket behavior in #189 before release.