Repository navigation
fix: inspect non-replayable Codex diagnostic bodies - #201
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex quality diagnostics rejected ordinary Responses requests before reserving their send budget because reasoning recovery intentionally clears
GetBodyto prevent transparent POST replay. This repairs inspection of the actual outgoing body while preserving its bytes, encoding, length and non-replayable transport contract.The change is limited to diagnostics. Protocol, workspace identity and Team behavior remain in PR #200 so the corrected diagnostic build can collect a valid baseline before those changes are deployed.
The seven bundled plugin manifests advance to 0.2.12 because each signed package embeds this release's source revision. This avoids reusing an immutable plugin version for different package bytes; plugin functionality is unchanged.
Validation: the original code reproduced the failure through the real reasoning-recovery preparation path. All three new
TestCodexQualityWiretests passed (service 0.214s), covering plaintext/zstd, existing replayable snapshots, preserved outgoing bytes and replay policy, body close ownership, bounded reads, and zero budget/send on invalid bodies. Scoped formatting and diff checks passed; previously passed tests were reused.