Repository navigation
fix(accounts): one scheduling switch, next to the status column - #213
Merged
Merged
Conversation
The status column carried a second copy of the schedulable switch (added in the fork on 2026-07-29); both called the same toggle. Follow upstream: the status column shows the status badge (plus the last upstream error badge) and the single switch lives in the schedulable column, placed right after the status column as upstream orders them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The accounts table showed two switches for the same thing: the status column carried a copy of the schedulable switch
(added in the fork on 2026-07-29) and the schedulable column had its own; both called
handleToggleSchedulable. Thesite owner asked to merge them the way official sub2api does.
Following upstream v0.2.9 (
AccountsView.vuestatus / schedulable cells):them. Default hidden columns are unchanged, so the switch stays visible by default.
Frontend only:
AccountsView.vueand the column-order expectation inAccountsView.console.spec.ts.Verification
eslinton both files: 0 problems;vitest run src/views/admin/__tests__/AccountsView.console.spec.ts: 17 passed.badge and one switch side by side, pixel text contrast unchanged (min 4.63 light / 5.04 dark).
🤖 Generated with Claude Code