Repository navigation
refactor(codex): one identity resolver per purpose, no unused context - #237
Merged
Merged
Conversation
The Codex identity resolvers kept a context parameter and a "...Context" twin from the dispatch layer removed in #233. Fold each pair into one function: resolveCodexOutboundIdentityForAccount, enforceCodexIdentityHeadersForAccount and resolveCodexIdentitySnapshot. The one real failure is unchanged: an identity whose version cannot form a valid User-Agent still fails the send. The predictor that only reads the identity for the sandbox tag keeps ignoring that error explicitly. The five account-test messages that named a "policy" now say what failed: "Codex client identity is invalid: ...". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#233 removed the native Codex runtime host and its dispatch layer. Three identity functions kept what only existed for it: an unused context parameter and a
...Contexttwin each. Five account-test messages still said "Codex identity policy unavailable", naming a policy that no longer exists. #233 deferred these so they would not collide with the v0.2.13 sync; that sync is merged now.Change
resolveCodexOutboundIdentityForAccount(returns the identity and an error),enforceCodexIdentityHeadersForAccount, andresolveCodexIdentitySnapshot. The bodies are the former...Contextbodies.Codex client identity is invalid: <error>.codexruntime/profiledrops "Policy" from its name.No request changes what it sends or when it fails.
Verification
go build ./...;go vetwith no tag and with-tags uniton the touched packages;Not run: full suites, real model calls.
🤖 Generated with Claude Code