[HTExplicit]

Problem

Features that were removed from the fork (Cindy, the plugin host, quota overdraft) left placeholders in the backend: unused parameters, error returns that are nil on every path, conditions that are always false, fields that are only written or never assigned, and functions with no production caller. The owner's rule is that a retired feature leaves nothing behind.

Change

Each item was judged by the commit that introduced it. It is restored to the upstream v0.2.13 form where upstream has the same function, and to the fork's form from before the feature elsewhere.

Two placeholder-context functions (first commit)

• resolveOpenAIForwardModelContext only returned resolveOpenAIForwardModel with a nil error. Its 14 callers lose an error branch that could never run. Nine now match upstream byte for byte; five are fork-only lines restored to their pre-Cindy form.
• isOpenAIAccountRuntimeBlockedContext held the body of isOpenAIAccountRuntimeBlocked behind an unused context. One function remains.

The same kind, found by review (second commit)

• Billing (openai_gateway_usage.go), back to upstream's shape:
  • no unused account / tokens parameters;
  • calculateOpenAIImageCost returns the cost only, since its error was nil on all five paths;
  • the duplicated channel-pricing branch is gone.
• Result structs: fields that were never assigned (CacheCreation5mTokens, CacheCreation1hTokens, UsageInputTokensExcludeCache) or only written (ImageInputCount) are removed.
• Runtime block:
  • a condition that was always false after normalisation is removed;
  • the persisted-cooldown zero guard and the stale-entry fallback, neither reachable in production, are removed.
• Account tests: an unused context parameter on two stream processors and a duplicated service field are removed.
• Account tools: the plugin-contract methods with no caller, the always-false capability check, and write-only invocation fields are removed.
• Blank parameters whose reason is gone are dropped from their signatures across handler, repository and service. wire_gen.go is regenerated with wire v0.7.0.
• Functions with no production caller are removed with their tests.

Kept on purpose

• Blank parameters required by an interface, a callback or wire ordering.
• Signatures kept identical to upstream.

No request changes what it sends, bills or fails on.

Verification

• gofmt; go build ./... (default and GOOS=linux); go vet ./... with no tag and with -tags unit; go vet -tags integration on repository, service and handler; wire diff clean;
• targeted tests for usage and image cost, identified pricing, runtime block and breaker, account tests, count-tokens failover, model context capacity, image tools and account tools, re-run after rebasing on feat(accounts): find accounts by upstream API key from the account search #239-fix(accounts): upstream billing rates resolve the page the account list shows #241;
• three review lenses, each finding verified: billing equivalence line by line against upstream, behaviour, completeness with an AST scan against upstream. 11 findings confirmed; 10 fixed. The remaining one needs an owner decision: Image Studio has had no model source since the Cindy removal, so the subsystem cannot create jobs.

Not run locally: golangci-lint (the local binary cannot read Go 1.27 export data; CI runs it), full suites, real model calls.

🤖 Generated with Claude Code