Repository navigation
chore(accounts): delete the billing-rate interval that never started - #243
Merged
Merged
Conversation
The account page declared a 5-minute refresh of the upstream billing rates
with useIntervalFn(..., { immediate: false }) and discarded the return value.
@vueuse only starts such an interval through resume(), which nothing called,
so the timer never ran. The rates are refreshed after a billing probe, as
before.
The line is upstream's. The owner decided on 2026-10-04 not to enable the
refresh and to delete the line; the code it alone could reach is left as
upstream has it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The account page declares a 5-minute refresh of the upstream billing rates:
With
immediate: falsethe interval only starts through the returnedresume(), and the return value is discarded, so the timer has never run (@vueuse 10.11; the same line is in upstream). The rates are refreshed in one place only: after a billing probe.Change
Delete that line. The owner decided on 2026-10-04 not to enable the periodic refresh and to remove the dead timer.
Scope, also the owner's choice: only this line. The code that only the timer could reach (the non-forced branch of
refreshUpstreamBillingRates, theforceparameter, the ETag reuse) stays as upstream has it, so the fork differs from upstream by this one line. If upstream later starts the timer, the next sync keeps it deleted.No runtime change: nothing that ran before stops running.
Verification
vue-tsc --noEmit.AccountsView.console,bulkEdit,selectionScope): 44 tests pass.useIntervalFnis still imported for the page's other three intervals.Not run: full suites. No release is cut for this change alone; it ships with the next one.
🤖 Generated with Claude Code